Review comments from Siva #4
Description
Opening questions
- I have read the document for Wallet Building Block v1.0.0-rc
- I have read the Release Notes for Wallet Building Block v1.0.0-rc
- I agree to follow the GovStack Code of Conduct
Are these features and the model conceptually complete?
While it provides a high-level overview, the "Issuer-Holder-Verifier Model" section can be further enhanced by detailing how security is strengthened through biometric binding, which ensures the credential is cryptographically linked to the holder’s identity. Additionally, elaboration is needed on how trust is established between the Issuer and the Verifier.
In the "Interoperability" section, more clarity can be added on how digital wallets can achieve interoperability, particularly by adhering to open standards such as W3C Verifiable Credentials, DIDComm, OpenID for Verifiable Presentations (OIDC4VP). These standards allow different wallet implementations to seamlessly exchange credentials across ecosystems while preserving privacy and trust.
Are there any concepts from those listed that you would like to provide feedback on?
From a document flow perspective, it is recommended to present the terminology before the description, as several terms are referenced within the description and should be clearly understood upfront.
As a general comment, the terms Issuer, Wallet, and Verifier should be used consistently and uniformly throughout the document to maintain clarity and avoid confusion. Any variations or interchangeable terms should be standardized or clearly defined upfront.
Are there any concepts that are important, but not considered, on this list?
Consider adding "key rotation" as a critical security mechanism to enhance tamper resistance. Regularly rotating cryptographic keys—especially for Issuers and Verifiers—helps mitigate the risk of key compromise, strengthens credential integrity over time
From the functionalities listed, would you like to provide feedback on their completeness?
How about covering compromise scenarios, specifically addressing what happens when a wallet or issuer is compromised. This should cover:
Revocation mechanisms to invalidate issued credentials
Are there any functionalities related to Digital Credentials Wallet that are not considered here?
How wallet backup and recovery procedures can mitigate data loss or misuse
Out of the requirements listed, would you like to provide feedback on the completeness of the description of the requirements, or on the requirement level assigned?
How about adding couple of sections for Recommended features
Key Management and Rotation
How the system recovers from security breaches
Are there any requirements that are necessary to Digital Credentials Wallet that are not considered here?
No response
Out of the requirements listed, would you like to provide feedback on the completeness of the description of the requirements, or on the requirement level assigned?
Although there is a touch base on status checks in 6.3, it's important to make revocation a distinct requirement
Support and need for Multiple Credential Formats
Are there any requirements that are necessary to Digital Credentials Wallet that are not considered here?
No response
Out of the data schemas provided, would you like to provide feedback on the completeness and formats of the schema definitions? Please go into as much detail as you can
Since DIDs are referenced across how about outline the core DID document structure
Are there any data structures that are necessary to Digital Credentials Wallet that are not considered here?
No response
Out of the API endpoints, available verbs and schemas provided, would you like to provide feedback on the completeness of them? Please go into as much detail as you can
Revocation is a critical feature should detail out on how it is achieved. how wallets detect and reflect revocation status, and how verifiers can check the validity of a credential.
Are there any data structures that are necessary to Digital Credentials Wallet that are not considered here?
No response
Out of the available workflows, would you like to provide feedback on the completeness of them? Please go into as much detail as you can
Revocation as a key area. A dedicated workflow should describe how revocation is managed post-issuance.
Are there extra workflows that are necessary to Digital Credentials Wallet that are not considered here?
Wallet Backup and Recovery Workflow