Add a test for when a resolver returns a failed Future (as opposed to throwing an error )and fix the implementation of completeValueCatchingError

Author: sportlabsMike

Tests/GraphQLTests/FieldExecutionStrategyTests/FieldExecutionStrategyTests.swift

@@ -38,6 +38,20 @@ class FieldExecutionStrategyTests: XCTestCase {
                             msg: "\(info.fieldName): \(info.path.last as! String)"
                         )
                 }
+                ),
+                "futureBang": GraphQLField(
+                    type: GraphQLString,
+                    resolve: { (_, _, _, eventLoopGroup, info: GraphQLResolveInfo) in
+                        let g = DispatchGroup()
+                        g.enter()
+                        DispatchQueue.global().asyncAfter(wallDeadline: .now() + 0.1) {
+                            g.leave()
+                        }
+                        g.wait()
+                        return eventLoopGroup.next().newFailedFuture(error: StrategyError.exampleError(
+                            msg: "\(info.fieldName): \(info.path.last as! String)"
+                        ))
+                }
                 )
             ]
         )
@@ -81,8 +95,24 @@ class FieldExecutionStrategyTests: XCTestCase {
             ]
         ]
     ]
+    
+    let singleFailedFutureQuery = "{ futureBang }"
+    let singleFailedFutureExpected: Map = [
+        "data": [
+            "futureBang": nil
+        ],
+        "errors": [
+            [
+                "locations": [
+                    ["column": 3, "line": 1]
+                ],
+                "message": "exampleError(msg: \"futureBang: futureBang\")",
+                "path":["futureBang"]
+            ]
+        ]
+    ]
 
-    let multiThrowsQuery = "{ a: bang b: bang c: bang d: bang e: bang f: bang g: bang h: bang i: bang j: bang }"
+    let multiThrowsQuery = "{ a: bang b: bang c: bang d: bang e: bang f: bang g: bang h: bang i: bang j: futureBang }"
     let multiThrowsExpectedData: Map = [
         "a": nil,
         "b": nil,
@@ -163,7 +193,7 @@ class FieldExecutionStrategyTests: XCTestCase {
             "locations": [
                 ["column": 75, "line": 1]
             ],
-            "message": "exampleError(msg: \"bang: j\")",
+            "message": "exampleError(msg: \"futureBang: j\")",
             "path":["j"]
         ],
         ]
@@ -210,6 +240,22 @@ class FieldExecutionStrategyTests: XCTestCase {
         XCTAssertEqual(result.value, singleThrowsExpected)
         //XCTAssertEqualWithAccuracy(0.1, result.seconds, accuracy: 0.25)
     }
+    
+    func testSerialFieldExecutionStrategyWithSingleFieldFailedFuture() throws {
+        let eventLoopGroup = MultiThreadedEventLoopGroup(numThreads: 1)
+        defer {
+            XCTAssertNoThrow(try eventLoopGroup.syncShutdownGracefully())
+        }
+        
+        let result = try timing(try graphql(
+            queryStrategy: SerialFieldExecutionStrategy(),
+            schema: schema,
+            request: singleFailedFutureQuery,
+            eventLoopGroup: eventLoopGroup
+            ).wait())
+        XCTAssertEqual(result.value, singleFailedFutureExpected)
+        //XCTAssertEqualWithAccuracy(0.1, result.seconds, accuracy: 0.25)
+    }
 
     func testSerialFieldExecutionStrategyWithMultipleFields() throws {
         let eventLoopGroup = MultiThreadedEventLoopGroup(numThreads: 1)
@@ -324,6 +370,7 @@ extension FieldExecutionStrategyTests {
         return [
             ("testSerialFieldExecutionStrategyWithSingleField", testSerialFieldExecutionStrategyWithSingleField),
             ("testSerialFieldExecutionStrategyWithSingleFieldError", testSerialFieldExecutionStrategyWithSingleFieldError),
+            ("testSerialFieldExecutionStrategyWithSingleFieldFailedFuture", testSerialFieldExecutionStrategyWithSingleFieldFailedFuture),
             ("testSerialFieldExecutionStrategyWithMultipleFields", testSerialFieldExecutionStrategyWithMultipleFields),
             ("testSerialFieldExecutionStrategyWithMultipleFieldErrors", testSerialFieldExecutionStrategyWithMultipleFieldErrors),
             ("testConcurrentDispatchFieldExecutionStrategyWithSingleField", testConcurrentDispatchFieldExecutionStrategyWithSingleField),