Make split node return Vec<String> and remove count_elements node

Author: TrueDoctor

node-graph/gcore/src/graphic.rs

@@ -451,6 +451,7 @@ fn index<T: AtIndex + Clone + Default>(
 		Vec<u32>,
 		Vec<u64>,
 		Vec<DVec2>,
+		Vec<String>,
 		Table<Artboard>,
 		Table<Graphic>,
 		Table<Vector>,

node-graph/gcore/src/logic.rs

@@ -69,18 +69,11 @@ fn string_length(_: impl Ctx, string: String) -> f64 {
 	string.chars().count() as f64
 }
 
-// Get an indexed part of string whitch separated a specified delimeter ("1;2;3" e.t.c.)
+// Spliet a string by a specified delimeter ("1;2;3" e.t.c.) and return a vector of strings
 #[node_macro::node(category("Text"))]
-fn substring_by_index(_: impl Ctx, string: String, #[default("\\n")] delimeter: String, index: u32) -> String {
+fn split(_: impl Ctx, string: String, #[default("\\n")] delimeter: String) -> Vec<String> {
 	let delimeter = delimeter.replace("\\n", "\n");
-	string.split(&delimeter).nth(index as usize).unwrap_or("").to_owned()
-}
-
-// Get amount substrings like ";" in string (useful for check max index in substring_by_index)
-#[node_macro::node(category("Text"))]
-fn count_substring(_: impl Ctx, string: String, #[default("\\n")] substring: String) -> f64 {
-	let substring = substring.replace("\\n", "\n");
-	string.matches(&substring).count() as f64
+	string.split(&delimeter).map(|x| x.to_string()).collect()
 }
 
 /// Evaluates either the "If True" or "If False" input branch based on whether the input condition is true or false.

node-graph/gcore/src/vector/vector_nodes.rs

@@ -1954,11 +1954,28 @@ fn point_inside(_: impl Ctx, source: Table<Vector>, point: DVec2) -> bool {
 	source.into_iter().any(|row| row.element.check_point_inside_shape(row.transform, point))
 }
 
+trait Count {
+	fn count(&self) -> usize;
+}
+impl<T> Count for Table<T> {
+	fn count(&self) -> usize {
+		self.len()
+	}
+}
+impl<T> Count for Vec<T> {
+	fn count(&self) -> usize {
+		self.len()
+	}
+}
+
 // TODO: Return u32, u64, or usize instead of f64 after #1621 is resolved and has allowed us to implement automatic type conversion in the node graph for nodes with generic type inputs.
 // TODO: (Currently automatic type conversion only works for concrete types, via the Graphene preprocessor and not the full Graphene type system.)
 #[node_macro::node(category("General"), path(graphene_core::vector))]
-async fn count_elements<I>(_: impl Ctx, #[implementations(Table<Graphic>, Table<Vector>, Table<Raster<CPU>>, Table<Raster<GPU>>, Table<Color>, Table<GradientStops>)] source: Table<I>) -> f64 {
-	source.len() as f64
+async fn count_elements<I: Count>(
+	_: impl Ctx,
+	#[implementations(Table<Graphic>, Table<Vector>, Table<Raster<CPU>>, Table<Raster<GPU>>, Table<Color>, Table<GradientStops>, Vec<String>, Vec<f64>, Vec<DVec2>)] source: I,
+) -> f64 {
+	source.count() as f64
 }
 
 #[node_macro::node(category("Vector: Measure"), path(graphene_core::vector))]