Remove site dependency in hxml target flag test (#668)

The `testInstallHxmlWithBackend` test require lib.haxe.org to be up so
it can fetch the server's hxcpp version, which is not good if we are
redeploying the server because it's down.

The new test just tests the LibFlagData.fromHxml function directly, to
ensure no duplication there. We could also add an integration test in
future.

Author: tobil4sk

test/HaxelibTests.hx

@@ -69,6 +69,7 @@ class HaxelibTests {
 		r.add(new TestRemoveSymlinks());
 		r.add(new TestRemoveSymlinksBroken());
 		r.add(new TestInstaller());
+		r.add(new TestLibFlagData());
 		r.add(new TestRepoManager());
 		r.add(new TestRepoReformatter());
 		r.add(new TestRepoReformatterOnLocal());

test/libraries/InstallDeps/cpp-single.hxml

@@ -0,0 +1 @@
+-cpp bin

test/libraries/InstallDeps/cpp.hxml

@@ -1,2 +1 @@
--cpp bin
 --cpp bin

test/tests/TestInstaller.hx

@@ -75,28 +75,6 @@ class TestInstaller extends TestBase {
 		assertFalse(FileSystem.exists(Path.join([lib, "git", "README.md"])));
 	}
 
-	public function testInstallHxmlWithBackend() {
-		// inferred from -cpp/--cpp flags
-		installer.installFromHxml("cpp.hxml", (libs) -> {
-			assertEquals(1, Lambda.count(libs, (lib) -> lib.name == "hxcpp"));
-			return false;
-		});
-
-		// specified explicitly
-		// test for issue #511
-		installer.installFromHxml("target-lib.hxml", (libs) -> {
-			assertEquals(1, Lambda.count(libs, (lib) -> lib.name == "hxcpp"));
-			return false;
-		});
-
-		// specified explicitly with non-standard capitalisation
-		installer.installFromHxml("target-lib-uppercase.hxml", (libs) -> {
-			assertEquals(1, Lambda.count(libs, (lib) -> lib.name == "HXCPP"));
-			assertEquals(0, Lambda.count(libs, (lib) -> lib.name == "hxcpp"));
-			return false;
-		});
-	}
-
 	public function testReinstallHxml() {
 		installer.installFromHxml("git-deps.hxml");
 

test/tests/TestLibFlagData.hx

@@ -0,0 +1,48 @@
+package tests;
+
+import haxe.io.Path;
+import haxelib.api.LibFlagData;
+
+using Lambda;
+
+class TestLibFlagData extends TestBase {
+
+	static var CWD:String = null;
+
+	override function setup() {
+		CWD = Sys.getCwd();
+
+		final dir = Path.join([CWD, "test/libraries/InstallDeps"]);
+		Sys.setCwd(dir);
+	}
+
+	override function tearDown() {
+		Sys.setCwd(CWD);
+	}
+
+	function testTargetFlag() {
+		final libraries = fromHxml("cpp.hxml");
+
+		assertEquals(1, libraries.count(f -> f.name == "hxcpp"));
+
+		final libraries = fromHxml("cpp-single.hxml");
+
+		assertEquals(1, libraries.count(f -> f.name == "hxcpp"));
+	}
+
+	// test for issue #511
+	function testBackendExplicit() {
+		final libraries = fromHxml("target-lib.hxml");
+
+		assertEquals(1, libraries.count(f -> f.name == "hxcpp"));
+	}
+
+	// specified explicitly with non-standard capitalisation
+	function testBackendExplicitUppercase() {
+		final libraries = fromHxml("target-lib-uppercase.hxml");
+
+		assertEquals(1, libraries.count(f -> f.name == "HXCPP"));
+		assertEquals(0, libraries.count(f -> f.name == "hxcpp"));
+	}
+
+}