Fix: Shorten embedding filenames using model_id_to_filename (#122) #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Issue #122 by shortening embedding output filenames using a simplified function
model_id_to_filename(), which extracts the final part of the HuggingFace model ID.Changes Made
model_id_to_filename()function to extract short model namescookbook/populate_embeddings.ipynbOutcome
This resolves the issue of long file names like:
prompt_sentences-sentence-transformers-all-MiniLM-L6-v2.jsonand converts them to shorter ones like:
prompt_sentences-all-minilm-l6-v2.jsonLet me know if further refinements are needed!