Don't add empty values (because of missing attribute mappings) in DataConverter.to_internal_filter.

Author: Rebecka Gulliksson

src/satosa/internal_data.py

@@ -69,9 +69,12 @@ def to_internal_filter(self, external_type, external_keys, case_insensitive=Fals
         """
         internal_keys = set()
         for external_key in external_keys:
-            internal_keys.add(
-                self.external2internal_attribute_name_mapping[external_type].get(external_key,
-                                                                                 case_insensitive))
+            internal_key = self.external2internal_attribute_name_mapping[external_type].get(
+                external_key,
+                case_insensitive)
+
+            if internal_key:
+                internal_keys.add(internal_key)
 
         return internal_keys
 

tests/satosa/test_internal_data.py

@@ -232,6 +232,24 @@ def test_to_internal_profile_missing_attribute_mapping(self):
         assert "mail" not in internal_repr  # no mapping for the 'mail' attribute in the 'bar' profile
         assert internal_repr["id"] == ["uid"]
 
+    def test_to_internal_filter_profile_missing_attribute_mapping(self):
+        mapping = {
+            "attributes": {
+                "mail": {
+                    "foo": ["email"],
+                },
+                "id": {
+                    "foo": ["id"],
+                    "bar": ["uid"],
+                }
+            },
+        }
+
+        converter = DataConverter(mapping)
+        filter = converter.to_internal_filter("bar", ["email", "uid"])
+        assert Counter(filter) == Counter(["id"])
+
+
     @pytest.mark.parametrize("attribute_value", [
         {"email": "test@example.com"},
         {"email": ["test@example.com"]}