Better exception handling for Malformed SAML Response

Author: peppelinux

djangosaml2/backends.py

@@ -77,7 +77,7 @@ def _extract_user_identifier_params(self, session_info: dict, attributes: dict,
 
         # Lookup value
         if getattr(settings, 'SAML_USE_NAME_ID_AS_USERNAME', False):
-            if 'name_id' in session_info:
+            if session_info.get('name_id'):
                 logger.debug('name_id: %s', session_info['name_id'])
                 user_lookup_value = session_info['name_id'].text
             else:

djangosaml2/views.py

@@ -350,7 +350,10 @@ def post(self, request, attribute_mapping=None, create_unknown_user=None):
         except RequestVersionTooLow as e:
             _exception = e
             logger.exception("Received SAMLResponse have a deprecated SAML2 VERSION.")
-
+        except Exception as e:
+            _exception = e
+            logger.exception("SAMLResponse Error")
+        
         if _exception:
             return self.handle_acs_failure(request, exception=_exception)
         elif response is None: