Skip to content

Commit ff5332b

Browse files
committed
Added slider label & fixed button text aligning
1 parent 20d8651 commit ff5332b

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@impvis/components",
3-
"version": "1.2.0",
3+
"version": "1.2.1",
44
"license": "BSD-3-Clause",
55
"main": "./dist/impvis-components.js",
66
"unpkg": "./dist/impvis-components.umd.js",

src/components/Button/Button.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<button class="iv-button iv-drop-shadow-medium" @mouseover="mouseOn" @mouseleave="mouseOff" @click="buttonClick" :disabled="disabled">
2+
<button class="iv-button iv-drop-shadow-medium" style="height:100%" @mouseover="mouseOn" @mouseleave="mouseOff" @click="buttonClick" :disabled="disabled">
33
<slot>Default text</slot></button>
44
</template>
55

src/components/Slider/Slider.vue

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
<template>
2-
<div ref="sliderContainer">
2+
<label for="slider">{{sliderName}}
3+
<div ref="sliderContainer" id="slider">
34
<div class = "sliderGroup">
4-
<iv-bubble v-if="bubble" :sliderValue="value" :min="min" :max="max" :thumb_width="thumb_width" :value_marker_width="value_marker_width" :colorBubble="color.dark"/>
5+
<iv-bubble v-if="bubble" :sliderValue="value" :min="min" :max="max" :thumb_width="thumb_width" :value_marker_width="value_marker_width" :colorBubble="color.dark"/>
56
<input type="range" :style="cssColor" :class="[(playSlider)? 'iv-range-play' : 'iv-range']" v-model.number="value" :min="min" :max="max" :step="step" @mousedown="startDrag" @mousemove="emitSlider" @mouseup="stopDrag" @change="emitSliderAgain">
67
<iv-line-ticks v-if="lineTick" :sliderTicksList="tick_list" :thumb_width="thumb_width" :min="min" :max="max" :key="tick_line_key" />
78
<iv-num-ticks v-if="numTick" :sliderTicksList="tick_list" :thumb_width="thumb_width" :min="min" :max="max" :key="tick_num_key"/>
89
<iv-button v-if="resetButton" style="height:100%" @click="reset">Reset</iv-button>
910
</div>
1011
<iv-input-button v-if="sliderButtons" :sliderValue="value" :playSlider="playSlider" :buttonInput="buttonInput" :min="min" :max="max" :button_step_init="button_step_init" @inputButtonClicked="update_val_button"/>
1112
</div>
13+
</label>
1214
</template>
1315
<script>
1416
import lineTicksComp from './lineTicks.vue';
@@ -27,6 +29,10 @@ export default {
2729
"iv-button":Button
2830
},
2931
props:{
32+
name:{
33+
type:String,
34+
default: "Slider Name"
35+
},
3036
bubble:{
3137
type:Boolean,
3238
default:true
@@ -85,7 +91,7 @@ export default {
8591
},
8692
resetButton:{
8793
type:Boolean,
88-
default:true
94+
default:false
8995
},
9096
},
9197
data(){
@@ -101,6 +107,7 @@ export default {
101107
dragging: false,
102108
value_marker_width: 25,//same as the width of the marker showing the value
103109
thumb_width: 18,//same as the width of the range slider thumb
110+
sliderName: this.name,
104111
}
105112
},
106113
methods:{

0 commit comments

Comments
 (0)