ENH: Remove fftPadPositiveIndex

The spatial location was wrongly shifted when using this filter
Negative indices do not interfere with any processing.
The scripts using this fftPad should instead use the ITK core:
FFTPadImageFilter

Author: phcerdan

README.rst

@@ -300,15 +300,6 @@ maximize the response at every pixel.
   itkStructureTensor.hxx
 
 
-FFTPad but avoiding setting negative index, which is problematic working with
-neighborhoods.
-
-::
-
-  itkFFTPadPositiveIndexImageFilter.h
-  itkFFTPadPositiveIndexImageFilter.hxx
-
-
 Regular shrinkers without interpolation
 '''''''''''''''''''''''''''''''''''''''
 

examples/runRieszWaveletAnalysis.cpp

@@ -18,7 +18,7 @@
 
 #include "itkForwardFFTImageFilter.h"
 #include "itkInverseFFTImageFilter.h"
-#include "itkFFTPadPositiveIndexImageFilter.h"
+#include "itkFFTPadImageFilter.h"
 #include "itkWaveletFrequencyForward.h"
 #include "itkWaveletFrequencyInverse.h"
 #include "itkWaveletFrequencyForwardUndecimated.h"
@@ -74,7 +74,7 @@ runRieszWaveletPhaseAnalysis( const std::string& inputImage,
   reader->SetFileName( inputImage );
   reader->Update();
 
-  using FFTPadFilterType = itk::FFTPadPositiveIndexImageFilter<ImageType>;
+  using FFTPadFilterType = itk::FFTPadImageFilter<ImageType>;
   auto fftPadFilter = FFTPadFilterType::New();
   fftPadFilter->SetInput(reader->GetOutput());
   fftPadFilter->SetBoundaryConditionToConstant(0);

include/itkFFTPadPositiveIndexImageFilter.h

@@ -17,8 +17,6 @@ set(IsotropicWaveletsTests
     # Syntactic sugar utilities
     itkVectorInverseFFTImageFilterTest.cxx
     itkZeroDCImageFilterTest.cxx
-    # Alternative FFT padding
-    itkFFTPadPositiveIndexImageFilterTest.cxx
     # Output data for each wavelet to visualize with python.
     itkIsotropicWaveletFrequencyFunctionTest.cxx
     itkHeldIsotropicWaveletTest.cxx
@@ -344,14 +342,6 @@ itk_add_test(NAME itkFrequencyShrinkEvenTest
     ${ITK_TEST_OUTPUT_DIR}/itkFrequencyShrinkEvenTest2D.tiff
     2
     )
-##FFTPad
-# TODO: Add 2D Odd Data, current 512x512 input does not cover the class well. Other boundary conditions have been removed.
-itk_add_test(NAME itkFFTPadPositiveIndexImageFilterTestConstant
-  COMMAND IsotropicWaveletsTestDriver
-  itkFFTPadPositiveIndexImageFilterTest
-    DATA{Input/checkershadow_Lch_512x512.tiff}
-    ${ITK_TEST_OUTPUT_DIR}/itkFFTPadPositiveIndexImageFilterTestConstant.tiff 2 CONSTANT
-    )
 ## ZeroDC
 itk_add_test(NAME itkZeroDCImageFilterTest
   COMMAND IsotropicWaveletsTestDriver
@@ -388,8 +378,6 @@ if(ITK_USE_FFTWF)
       itkFrequencyExpandOddTest itkFrequencyShrinkOddTest)
 endif()
 
-itk_python_expression_add_test(NAME itkFFTPadPositiveIndexImageFilterPythonTest
-  EXPRESSION "instance = itk.FFTPadPositiveIndexImageFilter.New()")
 itk_python_expression_add_test(NAME itkFrequencyExpandImageFilterPythonTest
   EXPRESSION "instance = itk.FrequencyExpandImageFilter.New()")
 itk_python_expression_add_test(NAME itkFrequencyFunctionPythonTest