Fix Xcode 9 lint warnings

Author: vbabenkoru

Iterable-iOS-SDK/IterableAPI.m

@@ -334,7 +334,7 @@ + (OnSuccessHandler)defaultOnSuccess:(NSString *)identifier
  
  @abstract default failure completion handler; warning logs the result from Iterable
  
- @param identifier an identifier for what succeeded; pass in something like the function name
+ @param identifier an identifier for what failed; pass in something like the function name
  
  @return a completion handler for use with `onFailure` of `sendRequest:onSuccess:onFailure:`
  */
@@ -718,7 +718,7 @@ - (void)updateEmail:(NSString *)newEmail onSuccess:(OnSuccessHandler)onSuccess o
 
         NSURLRequest *request = [self createRequestForAction:ENDPOINT_UPDATE_EMAIL withArgs:args];
         [self sendRequest:request onSuccess:^(NSDictionary *dictionary) {
-            _email = newEmail;
+            self->_email = newEmail;
             if (onSuccess) {
                 onSuccess(dictionary);
             }

Iterable-iOS-SDK/IterableInAppHTMLViewController.m

@@ -236,13 +236,13 @@ - (BOOL)webView:(UIWebView *)webView shouldStartLoadWithRequest:(NSURLRequest *)
             callbackURL = strNoURLScheme;
         }
         [self dismissViewControllerAnimated:NO completion:^{
-            if (_customBlockCallback != nil) {
-                _customBlockCallback(callbackURL);
+            if (self.customBlockCallback != nil) {
+                self.customBlockCallback(callbackURL);
             }
 
-            if (_trackParams != nil) {
+            if (self.trackParams != nil) {
                 IterableAPI *api = IterableAPI.sharedInstance;
-                [api trackInAppClick:_trackParams.messageId buttonURL:destinationURL];
+                [api trackInAppClick:self.trackParams.messageId buttonURL:destinationURL];
             }
         }];
         return NO;

Iterable-iOS-SDK/IterableLogging.h

@@ -14,7 +14,7 @@
 ////////////////////////
 
 // function that appends STDERR to the asl logger; uses dispatch_once to only do it once
-void AddStderrOnce();
+void AddStderrOnce(void);
 
 // heavily inspired by http://doing-it-wrong.mikeweller.com/2012/07/youre-doing-it-wrong-1-nslogdebug-ios.html
 // and http://stackoverflow.com/questions/300673/is-it-true-that-one-should-not-use-nslog-on-production-code