DropDown menu in MainTable rows (#14475)

* Added combo box in main table for content selectors

* Update CHANGELOG with new features

Added a drop-down menu for custom fields in the main table.

* Update CHANGELOG with issue reference for drop-down menu

Added a reference to issue #14087 for the drop-down menu feature.

* Update CHANGELOG for style

* Update CHANGELOG.md

Minor changes  on the issue #14087

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

* add new line for arguments

---------

Co-authored-by: Mélina Wang <dgtrhb@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

Author: 3 people

CHANGELOG.md

@@ -11,6 +11,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 
 ### Added
 
+- We added a drop-down menu to those custom fields in the main table for which content selector values exists. [#14087](https://github.com/JabRef/jabref/issues/14087)
 - We added a "Jump to Field" dialog (`Ctrl+J`) to quickly search for and navigate to any field across all tabs. [#12276](https://github.com/JabRef/jabref/issues/12276).
 - We made the "Configure API key" option in the Web Search preferences tab searchable via preferences search. [#13929](https://github.com/JabRef/jabref/issues/13929)
 - We added the integrity check to the jabkit cli application. [#13848](https://github.com/JabRef/jabref/issues/13848)

jabgui/src/main/java/org/jabref/gui/maintable/MainTableColumnFactory.java

@@ -24,6 +24,7 @@
 import org.jabref.gui.StateManager;
 import org.jabref.gui.icon.IconTheme;
 import org.jabref.gui.icon.JabRefIcon;
+import org.jabref.gui.maintable.columns.ContentSelectorColumn;
 import org.jabref.gui.maintable.columns.FieldColumn;
 import org.jabref.gui.maintable.columns.FileColumn;
 import org.jabref.gui.maintable.columns.LibraryColumn;
@@ -122,7 +123,14 @@ public MainTableColumnFactory(@NonNull BibDatabaseContext database,
                 break;
             case NORMALFIELD:
                 if (!column.getQualifier().isBlank()) {
-                    returnColumn = createFieldColumn(column, tooltip);
+                    Field field = FieldFactory.parseField(column.getQualifier());
+                    List<String> values = database.getMetaData().getContentSelectorValuesForField(field);
+
+                    if (values != null && !values.isEmpty()) {
+                        returnColumn = createContentSelectorColumn(column, values);
+                    } else {
+                        returnColumn = createFieldColumn(column, tooltip);
+                    }
                 }
                 break;
             default:
@@ -297,6 +305,14 @@ private TableColumn<BibEntryTableViewModel, Optional<SpecialFieldValueViewModel>
         return new SpecialFieldColumn(columnModel, preferences, undoManager);
     }
 
+    /**
+     * Creates a column for fields with content selectors.
+     */
+    private TableColumn<BibEntryTableViewModel, ?> createContentSelectorColumn(MainTableColumnModel columnModel,
+                                                                               List<String> values) {
+        return new ContentSelectorColumn(columnModel, values, undoManager);
+    }
+
     /**
      * Creates a column for all the linked files. Instead of creating a column for a single file type, like {@link
      * #createExtraFileColumn(MainTableColumnModel)} createExtraFileColumn} does, this creates one single column collecting all file links.

jabgui/src/main/java/org/jabref/gui/maintable/columns/ContentSelectorColumn.java

@@ -0,0 +1,67 @@
+package org.jabref.gui.maintable.columns;
+
+import java.util.List;
+import java.util.Optional;
+
+import javax.swing.undo.UndoManager;
+
+import javafx.scene.control.ContextMenu;
+import javafx.scene.control.MenuItem;
+
+import org.jabref.gui.maintable.BibEntryTableViewModel;
+import org.jabref.gui.maintable.MainTableColumnModel;
+import org.jabref.gui.undo.UndoableFieldChange;
+import org.jabref.gui.util.OptionalValueTableCellFactory;
+import org.jabref.logic.util.strings.StringUtil;
+import org.jabref.model.entry.BibEntry;
+import org.jabref.model.entry.field.Field;
+import org.jabref.model.entry.field.FieldFactory;
+import org.jabref.model.entry.field.OrFields;
+
+import com.tobiasdiez.easybind.EasyBind;
+
+/**
+ * A column for fields with content selectors.
+ */
+public class ContentSelectorColumn extends MainTableColumn<Optional<String>> {
+
+    private final List<String> values;
+    private final Field field;
+    private final UndoManager undoManager;
+
+    public ContentSelectorColumn(MainTableColumnModel model, List<String> values, UndoManager undoManager) {
+        super(model);
+        this.values = values;
+        this.undoManager = undoManager;
+        this.field = FieldFactory.parseField(model.getQualifier());
+
+        setText(field.getName());
+        setCellValueFactory(param -> EasyBind.map(param.getValue().getFields(new OrFields(field)),
+                value -> StringUtil.isBlank(value) ? Optional.empty() : Optional.of(value)));
+
+        new OptionalValueTableCellFactory<BibEntryTableViewModel, String>()
+                .withText(value -> value.orElse(""))
+                .withMenu(this::createMenu)
+                .install(this);
+
+        this.setSortable(true);
+    }
+
+    private ContextMenu createMenu(BibEntryTableViewModel model, Optional<String> value) {
+        ContextMenu menu = new ContextMenu();
+        BibEntry entry = model.getEntry();
+
+        for (String item : values) {
+            MenuItem menuItem = new MenuItem(item);
+            menuItem.setOnAction(event -> {
+                String oldValue = entry.getField(field).orElse(null);
+                entry.setField(field, item);
+                if (undoManager != null) {
+                    undoManager.addEdit(new UndoableFieldChange(entry, field, oldValue, item));
+                }
+            });
+            menu.getItems().add(menuItem);
+        }
+        return menu;
+    }
+}