Parameterize tests in logic.formatter.bibtexfields #14258
Merged
+66
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
previously requested changes
Nov 11, 2025
Comment on lines
29
to
35
| // combining accents | ||
| "{\\\"{a}}, a\u0308", | ||
| "{\\\"{a}}b, a\u0308b", | ||
|
|
||
| // plain unicode letters | ||
| "{\\\"{a}}, ä", | ||
| "{{$\\Epsilon$}}, \u0395" |
Member
There was a problem hiding this comment.
Please use text blocks here. See https://devdocs.jabref.org/code-howtos/testing.html#use-paramterizedtests for an example, Youc an use , as delimiter.
jablib/src/test/java/org/jabref/logic/formatter/bibtexfields/UnitsToLatexFormatterTest.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
status: changes-required
Member
…ue676 * upstream/main: (227 commits) Adapt welcome message (JabRef#14487) Add message when closing a PR Add collection of "all" AI features (JabRef#14438) Trigger conflict-detection on push on main (JabRef#14479) Add unassigned_comment on comment issue New Crowdin updates (JabRef#14483) Tweak labels also at merge conflicts Merge --remove-label and --add-label Remove SmartGroup and refactor groups factory (JabRef#14398) more debug Support html when parsing arXiv identifiers (JabRef#14474) Add debug and fix run Remove "ready-for-review" if changes are required Have label move as last step of comment Add pr number to output change files to file(s) (JabRef#14465) Add CDS archive (JabRef#14476) Fix adapting labels (JabRef#14477) Chore(deps): Bump jablib/src/main/resources/csl-styles (JabRef#14468) Chore(deps): Bump net.bytebuddy:byte-buddy in /versions (JabRef#14472) ...
Siedlerchr
approved these changes
Dec 1, 2025
Siedlerchr
added
status: ready-for-review
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #676
This PR refactors RemoveHyphenatedNewlinesFormatterTest, TrimWhitespaceFormatterTest, UnicodeConverterTest and UnitsToLatexFormatterTest to use parameterized tests (@CsvSource and @valuesource) following the one-assertion-per-test guideline.
Note: My classmates are also contributing to this issue.
@espertusnu
How to test: