refactor: Remove library installation calls from build scripts

Author: JakubAndrysek

.github/scripts/on-push.sh

@@ -14,7 +14,6 @@ function build {
     shift 6
     local sketches=("$@")
 
-    local INSTALL_LIBS="${SCRIPTS_DIR}/sketch_utils.sh install_libs"
     local BUILD_SKETCH="${SCRIPTS_DIR}/sketch_utils.sh build"
     local BUILD_SKETCHES="${SCRIPTS_DIR}/sketch_utils.sh chunk_build"
 
@@ -36,9 +35,6 @@ function build {
             local preprocessor_version
             sargs+=("-s" "$(dirname "$sketch")")
 
-            # Install libraries before building
-            ${INSTALL_LIBS} -ai "$ARDUINO_IDE_PATH" -s "$(dirname "$sketch")"
-
             if [ "$OS_IS_WINDOWS" == "1" ] && [ -d "$ARDUINO_IDE_PATH/tools-builder" ]; then
                 ctags_version=$(ls "$ARDUINO_IDE_PATH/tools-builder/ctags/")
                 preprocessor_version=$(ls "$ARDUINO_IDE_PATH/tools-builder/arduino-preprocessor/")

.github/scripts/sketch_utils.sh

@@ -244,6 +244,14 @@ function build_sketch { # build_sketch <ide_path> <user_path> <path-to-ino> [ext
         fi
     fi
 
+    # Install libraries from ci.json if they exist
+    install_libs -ai "$ide_path" -s "$sketchdir"
+    local install_result=$?
+    if [ $install_result -ne 0 ]; then
+        echo "ERROR: Library installation failed for $sketchname"
+        exit $install_result
+    fi
+
     ARDUINO_CACHE_DIR="$HOME/.arduino/cache.tmp"
     if [ -n "$ARDUINO_BUILD_DIR" ]; then
         build_dir="$ARDUINO_BUILD_DIR"
@@ -558,16 +566,16 @@ function build_sketches { # build_sketches <ide_path> <user_path> <target> <path
             continue
         fi
         echo ""
-        echo "Building Sketch Index $sketchnum - $sketchdirname"
 
         # Install libraries from ci.json if they exist
         install_libs -ai "$ide_path" -s "$sketchdir"
         local install_result=$?
         if [ $install_result -ne 0 ]; then
-            echo "ERROR: Library installation failed for $sketchdirname"
             return $install_result
         fi
 
+        echo "Building Sketch Index $sketchnum - $sketchdirname"
+
         build_sketch "${args[@]}" -s "$sketchdir" "${xtra_opts[@]}"
         local result=$?
         if [ $result -ne 0 ]; then
@@ -611,7 +619,7 @@ function install_libs { # install_libs <ide_path> <sketchdir> [-v]
         * )
             echo "ERROR: Unknown argument: $1"
             echo "USAGE: install_libs -ai <ide_path> -s <sketchdir> [-v]"
-            return 1
+            exit 1
             ;;
         esac
         shift
@@ -621,19 +629,19 @@ function install_libs { # install_libs <ide_path> <sketchdir> [-v]
     if [ -z "$ide_path" ]; then
         echo "ERROR: IDE path not provided"
         echo "USAGE: install_libs -ai <ide_path> -s <sketchdir> [-v]"
-        return 1
+        exit 1
     fi
 
     if [ -z "$sketchdir" ]; then
         echo "ERROR: Sketch directory not provided"
         echo "USAGE: install_libs -ai <ide_path> -s <sketchdir> [-v]"
-        return 1
+        exit 1
     fi
 
     # Check if arduino-cli exists
     if [ ! -f "$ide_path/arduino-cli" ]; then
         echo "ERROR: arduino-cli not found at $ide_path/arduino-cli"
-        return 1
+        exit 1
     fi
 
     # Check if ci.json exists
@@ -649,7 +657,7 @@ function install_libs { # install_libs <ide_path> <sketchdir> [-v]
         return 0
     elif [ "$libs_type" != "array" ]; then
         echo "ERROR: libs field in ci.json must be an array, found: $libs_type"
-        return 1
+        exit 1
     fi
 
     libs_count=$(jq -r '.libs | length' "$sketchdir/ci.json" 2>/dev/null)
@@ -684,6 +692,7 @@ function install_libs { # install_libs <ide_path> <sketchdir> [-v]
             enable_status=$?
             if [ $enable_status -ne 0 ]; then
                 echo "WARNING: Failed to enable unsafe installs, some libraries may fail to install"
+                exit $enable_status
             fi
         else
             [ "$verbose" = true ] && echo "Unsafe installs already enabled"
@@ -705,9 +714,6 @@ function install_libs { # install_libs <ide_path> <sketchdir> [-v]
                 # Capture both stdout and stderr, show only errors
                 output=$("$ide_path/arduino-cli" lib install --git-url "$lib" 2>&1)
                 install_status=$?
-                if [ $install_status -ne 0 ]; then
-                    echo "$output" | grep -E "Error|WARNING|WARN" || echo "$output"
-                fi
             fi
         else
             # Library name (with optional version)
@@ -721,6 +727,7 @@ function install_libs { # install_libs <ide_path> <sketchdir> [-v]
                 install_status=$?
                 if [ $install_status -ne 0 ]; then
                     echo "$output" | grep -E "Error|WARNING|WARN" || echo "$output"
+                    exit $install_status
                 fi
             fi
         fi
@@ -732,7 +739,7 @@ function install_libs { # install_libs <ide_path> <sketchdir> [-v]
                 [ "$verbose" = true ] && echo "Restoring original unsafe install setting..."
                 "$ide_path/arduino-cli" config set library.enable_unsafe_install false >/dev/null 2>&1
             fi
-            return $install_status
+            exit $install_status
         else
             [ "$verbose" = true ] && echo "Successfully installed library: $lib"
         fi

.github/scripts/tests_build.sh

@@ -75,9 +75,6 @@ if [ $chunk_build -eq 1 ]; then
 else
     BUILD_CMD="${SCRIPTS_DIR}/sketch_utils.sh build"
     args+=("-s" "$test_folder/$sketch")
-
-    # Install libraries before building individual sketch
-    "${SCRIPTS_DIR}/sketch_utils.sh" install_libs -ai "$ARDUINO_IDE_PATH" -s "$test_folder/$sketch"
 fi
 
 ${BUILD_CMD} "${args[@]}" "$@"