Skip to content

Optimize scan_memory_for_exact_value #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BonePolk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize scan_memory_for_exact_value #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions PyMemoryEditor/util/scan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,29 +19,26 @@ def scan_memory_for_exact_value(
"""
Search for an exact value at the memory region.

This method uses an efficient searching algorithm.
This method uses an efficient searching algorithm. Default find function literally)
"""
searcher = KMPSearch(target_value, target_value_size)
data = bytes(memory_region_data)
last_index = 0
found_index = data.find(target_value, 0)

for found_index in searcher.search(memory_region_data, memory_region_data_size):

# Return the found index if user is searching for an exact value.
while found_index != -1:
if comparison is ScanTypesEnum.EXACT_VALUE:
yield found_index
continue

# Return the interval between last_index and found_address, if user is searching for a different value.
for different_index in range(last_index, found_index):
yield different_index
last_index = found_index + 1
elif comparison is ScanTypesEnum.NOT_EXACT_VALUE:
for different_index in range(last_index, found_index):
yield different_index
last_index = found_index + 1
found_index = data.find(target_value, found_index+1)

# If user is searching for a different value, return the rest of the addresses that were not found.
if comparison is ScanTypesEnum.NOT_EXACT_VALUE:
for different_index in range(last_index, memory_region_data_size):
yield different_index


def scan_memory(
memory_region_data: Sequence,
memory_region_data_size: int,
Expand Down