Skip to content

Commit 6840e86

Browse files
committed
Remove get() and lazy for all dependencies, and sort all dependencies
Since ComposeBuildConfig.composeVersion is a static Sting and its parent is an object class we don't need to use get or lazy.
1 parent 440cc34 commit 6840e86

File tree

1 file changed

+29
-40
lines changed

1 file changed

+29
-40
lines changed

gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposePlugin.kt

Lines changed: 29 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ import org.jetbrains.compose.web.WebExtension
2929
import org.jetbrains.compose.web.internal.configureWeb
3030
import org.jetbrains.kotlin.gradle.plugin.KotlinDependencyHandler
3131

32-
internal val composeVersion get() = ComposeBuildConfig.composeVersion
33-
3432
abstract class ComposePlugin : Plugin<Project> {
3533
override fun apply(project: Project) {
3634
val composeExtension = project.extensions.create("compose", ComposeExtension::class.java, project)
@@ -65,28 +63,31 @@ abstract class ComposePlugin : Plugin<Project> {
6563
@Suppress("DEPRECATION")
6664
class Dependencies(project: Project) {
6765
val desktop = DesktopDependencies
68-
val animation get() = composeDependency("org.jetbrains.compose.animation:animation")
69-
val animationGraphics get() = composeDependency("org.jetbrains.compose.animation:animation-graphics")
70-
val foundation get() = composeDependency("org.jetbrains.compose.foundation:foundation")
71-
val material get() = composeDependency("org.jetbrains.compose.material:material")
72-
val material3 get() = composeDependency("org.jetbrains.compose.material3:material3")
73-
val material3AdaptiveNavigationSuite get() = composeDependency("org.jetbrains.compose.material3:material3-adaptive-navigation-suite")
74-
val runtime get() = composeDependency("org.jetbrains.compose.runtime:runtime")
75-
val runtimeSaveable get() = composeDependency("org.jetbrains.compose.runtime:runtime-saveable")
76-
val ui get() = composeDependency("org.jetbrains.compose.ui:ui")
66+
val animation = composeDependency("org.jetbrains.compose.animation:animation")
67+
val animationGraphics = composeDependency("org.jetbrains.compose.animation:animation-graphics")
68+
val foundation = composeDependency("org.jetbrains.compose.foundation:foundation")
69+
val material = composeDependency("org.jetbrains.compose.material:material")
70+
val material3 = composeDependency("org.jetbrains.compose.material3:material3")
71+
val material3AdaptiveNavigationSuite = composeDependency("org.jetbrains.compose.material3:material3-adaptive-navigation-suite")
72+
val runtime = composeDependency("org.jetbrains.compose.runtime:runtime")
73+
val runtimeSaveable = composeDependency("org.jetbrains.compose.runtime:runtime-saveable")
74+
val ui = composeDependency("org.jetbrains.compose.ui:ui")
75+
7776
@Deprecated("Use desktop.uiTestJUnit4", replaceWith = ReplaceWith("desktop.uiTestJUnit4"))
7877
@ExperimentalComposeLibrary
79-
val uiTestJUnit4 get() = composeDependency("org.jetbrains.compose.ui:ui-test-junit4")
78+
val uiTestJUnit4 = composeDependency("org.jetbrains.compose.ui:ui-test-junit4")
79+
8080
@ExperimentalComposeLibrary
81-
val uiTest get() = composeDependency("org.jetbrains.compose.ui:ui-test")
82-
val uiTooling get() = composeDependency("org.jetbrains.compose.ui:ui-tooling")
83-
val uiUtil get() = composeDependency("org.jetbrains.compose.ui:ui-util")
84-
val preview get() = composeDependency("org.jetbrains.compose.ui:ui-tooling-preview")
85-
val materialIconsExtended get() = "org.jetbrains.compose.material:material-icons-extended:1.7.3"
86-
val components get() = CommonComponentsDependencies
81+
val uiTest = composeDependency("org.jetbrains.compose.ui:ui-test")
82+
val uiTooling = composeDependency("org.jetbrains.compose.ui:ui-tooling")
83+
val uiUtil = composeDependency("org.jetbrains.compose.ui:ui-util")
84+
val preview = composeDependency("org.jetbrains.compose.ui:ui-tooling-preview")
85+
val materialIconsExtended = "org.jetbrains.compose.material:material-icons-extended:1.7.3"
86+
val components = CommonComponentsDependencies
87+
8788
@Deprecated("Use compose.html", replaceWith = ReplaceWith("html"))
88-
val web: WebDependencies get() = WebDependencies
89-
val html: HtmlDependencies get() = HtmlDependencies
89+
val web: WebDependencies = WebDependencies
90+
val html: HtmlDependencies = HtmlDependencies
9091
}
9192

9293
object DesktopDependencies {
@@ -100,7 +101,7 @@ abstract class ComposePlugin : Plugin<Project> {
100101
val macos_x64 = composeDependency("org.jetbrains.compose.desktop:desktop-jvm-macos-x64")
101102
val macos_arm64 = composeDependency("org.jetbrains.compose.desktop:desktop-jvm-macos-arm64")
102103

103-
val uiTestJUnit4 get() = composeDependency("org.jetbrains.compose.ui:ui-test-junit4")
104+
val uiTestJUnit4 = composeDependency("org.jetbrains.compose.ui:ui-test-junit4")
104105

105106
val currentOs by lazy {
106107
composeDependency("org.jetbrains.compose.desktop:desktop-jvm-${currentTarget.id}")
@@ -122,31 +123,19 @@ abstract class ComposePlugin : Plugin<Project> {
122123

123124
@Deprecated("Use compose.html")
124125
object WebDependencies {
125-
val core by lazy {
126-
composeDependency("org.jetbrains.compose.html:html-core")
127-
}
126+
val core = composeDependency("org.jetbrains.compose.html:html-core")
128127

129-
val svg by lazy {
130-
composeDependency("org.jetbrains.compose.html:html-svg")
131-
}
128+
val svg = composeDependency("org.jetbrains.compose.html:html-svg")
132129

133-
val testUtils by lazy {
134-
composeDependency("org.jetbrains.compose.html:html-test-utils")
135-
}
130+
val testUtils = composeDependency("org.jetbrains.compose.html:html-test-utils")
136131
}
137132

138133
object HtmlDependencies {
139-
val core by lazy {
140-
composeDependency("org.jetbrains.compose.html:html-core")
141-
}
134+
val core = composeDependency("org.jetbrains.compose.html:html-core")
142135

143-
val svg by lazy {
144-
composeDependency("org.jetbrains.compose.html:html-svg")
145-
}
136+
val svg = composeDependency("org.jetbrains.compose.html:html-svg")
146137

147-
val testUtils by lazy {
148-
composeDependency("org.jetbrains.compose.html:html-test-utils")
149-
}
138+
val testUtils = composeDependency("org.jetbrains.compose.html:html-test-utils")
150139
}
151140
}
152141

@@ -157,7 +146,7 @@ fun KotlinDependencyHandler.compose(groupWithArtifact: String) = composeDependen
157146

158147
fun DependencyHandler.compose(groupWithArtifact: String) = composeDependency(groupWithArtifact)
159148

160-
private fun composeDependency(groupWithArtifact: String) = "$groupWithArtifact:$composeVersion"
149+
private fun composeDependency(groupWithArtifact: String) = "$groupWithArtifact:${ComposeBuildConfig.composeVersion}"
161150

162151
private fun setUpGroovyDslExtensions(project: Project) {
163152
project.plugins.withId("org.jetbrains.kotlin.multiplatform") {

0 commit comments

Comments
 (0)