[platform] IJPL-204155 writing the CE migration marker file on all OSes

... (otherwise, the Vision page is not triggered) + cleanup (pointless is-fronted check; quick-fixes/suppressions)

GitOrigin-RevId: 0650804a9a5b6b3d1be91158b2c3715bdb84a4d9

Author: trespasserw

platform/platform-impl/src/com/intellij/util/singleProduct/MigrationToSingleProduct.kt

@@ -2,7 +2,6 @@
 package com.intellij.util.singleProduct
 
 import com.intellij.idea.AppMode
-import com.intellij.idea.AppModeAssertions
 import com.intellij.internal.InternalActionsBundle
 import com.intellij.internal.statistic.eventLog.EventLogGroup
 import com.intellij.internal.statistic.eventLog.events.EventId
@@ -49,20 +48,16 @@ private const val MIGRATION_FILE_MARKER = ".ce_migration_attempted"
 @ApiStatus.Internal
 fun migrateCommunityToSingleProductIfNeeded(args: List<String>) {
   if (
-    OS.CURRENT != OS.macOS ||
     !(PlatformUtils.isIdeaUltimate() || @Suppress("DEPRECATION") PlatformUtils.isPyCharmPro()) ||
-    isRemDev()
+    AppMode.isRemoteDevHost()
   ) return
 
   val currentDir = PathManager.getHomeDir().parent
   val currentDirName = currentDir.name
   val newDirName = currentDirName.replace(" CE", "").replace(" Community Edition", "")
   if (newDirName == currentDirName) return
 
-  val newDir = currentDir.resolveSibling(newDirName)
-  if (Files.exists(newDir)) return
-
-  // a marker file is used because standard storage is unavailable at this early startup stage
+  // a marker file is used because standard storage is unavailable at this early startup stage (used later to trigger the Vision page)
   val migrationAttemptMarker = PathManager.getConfigDir().resolve(MIGRATION_FILE_MARKER)
   try {
     Files.writeString(migrationAttemptMarker, "", StandardOpenOption.CREATE_NEW)
@@ -71,17 +66,19 @@ fun migrateCommunityToSingleProductIfNeeded(args: List<String>) {
     return
   }
 
+  if (!(OS.CURRENT == OS.macOS && currentDirName.endsWith(".app"))) return
+
+  val newDir = currentDir.resolveSibling(newDirName)
+  if (Files.exists(newDir)) return
+
   val renameCommand = listOf("/bin/mv", "-n", currentDir.toString(), newDir.toString())
   val startCommand = listOf(newDir.resolve("Contents/MacOS/${ApplicationNamesInfo.getInstance().scriptName}").toString()) + args
   Restarter.setMainAppArgs(args)  // fallback if the rename fails
   Restarter.scheduleRestart(false, renameCommand, startCommand)
   exitProcess(0)
 }
 
-private fun isRemDev(): Boolean = AppMode.isRemoteDevHost() || AppModeAssertions.isFrontend()
-
-private const val VISION_URL_MARKER = "\$__VISION_PAGE_SETTINGS_MEDIA_BASE_PATH__\$"
-
+private const val VISION_URL_MARKER = $$"$__VISION_PAGE_SETTINGS_MEDIA_BASE_PATH__$"
 private const val VISION_RESOURCE_PACKAGE_PREFIX = "migration"
 
 @ApiStatus.Internal
@@ -98,7 +95,7 @@ class MigrationStartupActivity : ProjectActivity {
 
   @OptIn(ExperimentalSerializationApi::class)
   override suspend fun execute(project: Project) {
-    if (!PlatformUtils.isIdeaUltimate() && !PlatformUtils.isPyCharmPro() || isRemDev()) {
+    if (!PlatformUtils.isIdeaUltimate() && @Suppress("DEPRECATION") !PlatformUtils.isPyCharmPro() || AppMode.isRemoteDevHost()) {
       return
     }
     val migrationAttemptMarker = PathManager.getConfigDir().resolve(MIGRATION_FILE_MARKER)
@@ -174,7 +171,7 @@ class MigrationStartupActivity : ProjectActivity {
 
 @ApiStatus.Internal
 private object MigrateToSingleProductCollector : CounterUsagesCollector() {
-  private val GROUP = EventLogGroup("migrate.to.single.product", 1)
+  private val GROUP = @Suppress("DEPRECATION") EventLogGroup("migrate.to.single.product", 1)
 
   @JvmField
   val WELCOME_PAGE_SHOWN: EventId = GROUP.registerEvent("vision.page.shown", "How many times button on welcome vision page was shown after patch update to SID")