KT-20357: Add sample usages for array constructor functions #5521
Conversation
oscarArismendi
requested review from
fzhinkin,
ilya-g and
qwwdfsad
as code owners
oscarArismendi
changed the title
|
Hi, just checking if I need to do anything else to move this toward review |
| /** | ||
| * Returns an array containing the specified [Double] numbers. | ||
| * | ||
| * @sample samples.collections.Arrays.Constructors.doubleArrayOf |
There was a problem hiding this comment.
Please update corresponding actual declarations.
There was a problem hiding this comment.
Did it in a74af86
Let me know if that's what you wanted
| class Constructors { | ||
| @Sample | ||
| fun doubleArrayOf() { | ||
| val doubleArray = doubleArrayOf(1.0, 2.5, 3.14) |
There was a problem hiding this comment.
It might make sense to showcase that these functions produce an empty array when invoked without any arguments. WDYT?
There was a problem hiding this comment.
Samples for array functions have been added as requested(Ref a74af86). I renamed the sample methods with a 'Sample' suffix to prevent recursive self-calls, but let me know what you think
fzhinkin
added
the
Standard Library Sample
| * Returns an array containing the specified elements. | ||
| */ | ||
| public expect inline fun <reified T> arrayOf(vararg elements: T): Array<T> | ||
|
|
There was a problem hiding this comment.
It also makes sense to add a similar sample for arrayOf ^
…rd library Related issue: KT-20357
…tions in standard library Related issue: KT-20357
oscarArismendi
force-pushed
the
KT-20357-array-of-samples
branch
from
0713c9e to
bbe6420
Compare
Related issue: KT-20357
oscarArismendi
force-pushed
the
KT-20357-array-of-samples
branch
from
bbe6420 to
b49f96e
Compare
2 participants
Added a sample function for constructors in
Library.kt.These are just the basics, but I remember when I was learning Kotlin that having examples for everything would’ve made me spend more time in the official documentation.
Related issue: KT-20357