Adding perfered engine to pretrained and minor fixes #14689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
DevinTDHa
changed the base branch from
master
to
release/623-release-candidate
default model no longer exists
This reverts commit 66d19f6.
DevinTDHa
force-pushed
the
adding-perfered-Engine-to-pretrained-and-minor-fixes
branch
from
3bc08d6 to
906c8b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr introduces two new mechanisms for pretrained models:
engineit will allow users to specify which enigne they would perfer to use and if a model is avaialable in multiple engines it will automatically pick the engine specified otherwise fall back to anotherengine. If no engine is specified the following priority order is used :
Onnx -> Tensorflow -> Openvino -> Unk
How Has This Been Tested?
Test locally via unit tests in python and scala
Tested on colab