assert domain compatibility in conversions (#193)

Author: jishnub

src/Spaces/Jacobi/JacobiOperators.jl

@@ -229,12 +229,14 @@ end
 # Assume m is compatible
 
 function Conversion(A::PolynomialSpace,B::Jacobi)
+    @assert domain(A) == domain(B)
     J = Jacobi(A)
     J == B ? ConcreteConversion(A,B) :
              ConversionWrapper(TimesOperator(Conversion(J,B),Conversion(A,J)))
 end
 
 function Conversion(A::Jacobi,B::PolynomialSpace)
+    @assert domain(A) == domain(B)
     J = Jacobi(B)
     J == A ? ConcreteConversion(A,B) :
              ConversionWrapper(TimesOperator(Conversion(J,B),Conversion(A,J)))
@@ -244,6 +246,7 @@ isequalminhalf(x) = x == -0.5
 isequalminhalf(@nospecialize ::Integer) = false
 
 function Conversion(A::Jacobi,B::Chebyshev)
+    @assert domain(A) == domain(B)
     if isequalminhalf(A.a) && isequalminhalf(A.b)
         ConcreteConversion(A,B)
     elseif A.a == A.b == 0
@@ -261,6 +264,7 @@ function Conversion(A::Jacobi,B::Chebyshev)
 end
 
 function Conversion(A::Chebyshev,B::Jacobi)
+    @assert domain(A) == domain(B)
     if isequalminhalf(B.a) && isequalminhalf(B.b)
         ConcreteConversion(A,B)
     elseif B.a == B.b == 0
@@ -279,6 +283,7 @@ end
 
 
 function Conversion(A::Jacobi,B::Ultraspherical)
+    @assert domain(A) == domain(B)
     if isequalminhalf(A.a) && isequalminhalf(A.b)
         ConversionWrapper(Conversion(Chebyshev(domain(A)),B)*
             ConcreteConversion(A,Chebyshev(domain(A))))
@@ -299,6 +304,7 @@ function Conversion(A::Jacobi,B::Ultraspherical)
 end
 
 function Conversion(A::Ultraspherical,B::Jacobi)
+    @assert domain(A) == domain(B)
     if isequalminhalf(B.a) && isequalminhalf(B.b)
         ConversionWrapper(ConcreteConversion(Chebyshev(domain(A)),B)*
             Conversion(A,Chebyshev(domain(A))))

src/Spaces/Ultraspherical/UltrasphericalOperators.jl

@@ -128,10 +128,10 @@ isequalhalf(x) = x == 0.5
 isequalhalf(::Integer) = false
 
 function Conversion(A::Chebyshev, B::Ultraspherical)
+    @assert domain(A) == domain(B)
     mB = order(B)
     d=domain(A)
     dB = domain(B)
-    d == dB || throw(ArgumentError("domains must be identical"))
     if isequalhalf(mB) || mB == 1
         return ConcreteConversion(A,B)
     elseif (isinteger(mB) || isapproxinteger_addhalf(mB)) && mB > 0
@@ -147,6 +147,7 @@ function Conversion(A::Chebyshev, B::Ultraspherical)
 end
 
 function Conversion(A::Ultraspherical,B::Chebyshev)
+    @assert domain(A) == domain(B)
     if isequalhalf(order(A)) && domain(A) == domain(B)
         return ConcreteConversion(A,B)
     end
@@ -158,10 +159,9 @@ maxspace_rule(A::Ultraspherical,B::Chebyshev) = A
 
 
 function Conversion(A::Ultraspherical,B::Ultraspherical)
+    @assert domain(A) == domain(B)
     a=order(A); b=order(B)
     d=domain(A)
-    dB = domain(B)
-    d == dB || throw(ArgumentError("domains must be identical"))
     if b==a
         return ConversionWrapper(Operator(I,A))
     elseif isapproxinteger(b-a) || isapproxinteger_addhalf(b-a)