constprop in jacobi derivative (#170)

* constprop in jacobi derivative

* specialize Derivative

* Version bump to v0.6.2

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "ApproxFunOrthogonalPolynomials"
 uuid = "b70543e2-c0d9-56b8-a290-0d4d6d4de211"
-version = "0.6.1"
+version = "0.6.2"
 
 [deps]
 ApproxFunBase = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"

src/Spaces/Jacobi/JacobiOperators.jl

@@ -1,14 +1,21 @@
 ## Derivative
 
-function Derivative(J::Jacobi,k::Number)
+# specialize Derivative so that this is type-inferred even without constant propagation
+Derivative(J::Jacobi) = ConcreteDerivative(J,1)
+@inline function _Derivative(J::Jacobi, k::Number)
     assert_integer(k)
     k==1 ? ConcreteDerivative(J,1) :
         DerivativeWrapper(
             TimesOperator(
                 Derivative(Jacobi(J.b+1,J.a+1,J.domain),k-1),ConcreteDerivative(J,1)),
         J, k)
 end
-
+@static if VERSION >= v"1.8"
+    Base.@constprop :aggressive Derivative(J::Jacobi, k::Number) =
+        _Derivative(J, k)
+else
+    Derivative(J::Jacobi, k::Number) = _Derivative(J, k)
+end
 
 
 rangespace(D::ConcreteDerivative{J}) where {J<:Jacobi}=Jacobi(D.space.b+D.order,D.space.a+D.order,domain(D))

test/JacobiTest.jl

@@ -110,15 +110,19 @@ using StaticArrays: SVector
     end
 
     @testset "Derivative" begin
-        D=Derivative(Jacobi(0.,1.,Segment(1.,0.)))
+        D = @inferred Derivative(Jacobi(0.,1.,Segment(1.,0.)))
+        if VERSION >= v"1.8"
+            D2 = @inferred (() -> Derivative(Jacobi(0.,1.,Segment(1.,0.)), 1))()
+            @test D2 == D
+        end
         @time testbandedoperator(D)
         # only one band should be populated
         @test bandwidths(D, 1) == -bandwidths(D, 2)
 
         @testset for d in [-1..1, 0..1]
             f = Fun(x->x^2, Chebyshev(d))
             C = space(f)
-            for J = Any[Jacobi(-0.5, -0.5, d), Legendre(d)]
+            for J = (Jacobi(-0.5, -0.5, d), Legendre(d))
                 g = (Derivative(J) * Conversion(C, J)) * f
                 h = Derivative(C) * f
                 @test g ≈ h
@@ -128,9 +132,9 @@ using StaticArrays: SVector
                 @test g ≈ h
             end
         end
-        @testset for S1 in Any[Jacobi(0,0),
-            Jacobi(0,0,1..2), Jacobi(2,2,1..2), Jacobi(0.5,2.5,1..2)],
-                S in Any[S1, NormalizedPolynomialSpace(S1)]
+        @testset for S1 in (Jacobi(0,0), Jacobi(0,0,1..2),
+                            Jacobi(2,2,1..2), Jacobi(0.5,2.5,1..2)),
+                S in (S1, NormalizedPolynomialSpace(S1))
             f = Fun(x->x^3 + 4x^2 + 2x + 6, S)
             @test Derivative(S) * f ≈ Fun(x->3x^2 + 8x + 2, S)
             @test Derivative(S)^2 * f ≈ Fun(x->6x+8, S)