interface norm and moments

Author: daanhb

src/bases/dictionary/basisfunction.jl

@@ -86,9 +86,8 @@ innerproduct(ϕ::AbstractBasisFunction, ψ::AbstractBasisFunction; options...) =
 innerproduct(φ::AbstractBasisFunction, ψ::AbstractBasisFunction, measure; options...) =
     dict_innerproduct(dictionary(φ), index(φ), dictionary(ψ), index(ψ), measure; options...)
 
-norm(φ::AbstractBasisFunction, μ = measure(φ); options...) = sqrt(innerproduct(φ, φ, μ; options...))
-
-norm(φ::AbstractBasisFunction, p::Real) = dict_norm(dictionary(φ), index(φ), p)
+norm(φ::AbstractBasisFunction; options...) = norm(φ, measure(φ); options...)
+norm(φ::AbstractBasisFunction, p; options...) = dict_norm(dictionary(φ), index(φ), p; options...)
 
 # The inner product of a basis function with another function: this is an analysis integral
 # We introduce a separate function name for this for easier dispatch.

src/bases/dictionary/dict_moments.jl

@@ -31,6 +31,6 @@ with respect to the given measure.
 function dict_norm(dict, idx, μ::Measure)
     checkdictionary(dict)
     @boundscheck checkbounds(dict, idx)
-    sqrt(innerproduct(dict, idx, dict, idx, μ))
+    sqrt(dict_innerproduct(dict, idx, dict, idx, μ))
 end
 dict_norm(dict, idx) = dict_norm(dict, idx, measure(dict))

src/bases/dictionary/dictionary.jl

@@ -137,7 +137,10 @@ ones(s::Dictionary) = ones(coefficienttype(s), s)
 # By default we assume that the native format corresponds to an array of the
 # same size as the set. This is not true, e.g., for multidicts.
 zeros(::Type{T}, s::Dictionary) where {T} = zeros(T, size(s))
-ones(::Type{T}, s::Dictionary) where {T} = ones(T, size(s))
+function ones(::Type{T}, s::Dictionary) where T
+    z = zeros(T, s)
+    z .= 1
+end
 
 "What is the type of the coefficient vector of the dictionary?"
 containertype(d::Dictionary) = typeof(zeros(d))

src/bases/fourier/sinc.jl

@@ -24,7 +24,7 @@ hasderivative(b::PeriodicSincFunctions) = false #for now
 hasantiderivative(b::PeriodicSincFunctions) = false #for now
 
 hasconstant(b::PeriodicSincFunctions) = true
-coefficients_of_one(b) = ones(numtype(b), size(b))
+coefficients_of_one(b::PeriodicSincFunctions) = ones(numtype(b), size(b))
 
 "Indices of translated sinc functions start at 0."
 struct SincIndex <: AbstractShiftedIndex{1}