Skip to content

Clearly differentiate functions that accept prefix vs. key #301

@omus

Description

@omus

I thought about using s3_purge_versions initially, but that purges versions of everything under the prefix, rather than just a specific path---and I very intentionally just want to be touching the specific path here.

Oh my b, I assumed you could provide a full path as the prefix to s3_purge_versions.

We should make an issue to make it clear on a convention for what functions deal with keys and which deal with prefixes. Right now it isn't clear and accidental usage of a prefix function when you though a key was used could be quite dangerous.

Originally posted by @omus in #299 (comment)

We should review the AWS S3 API before making a decision on what we want to do but my initial instinct is that we should have a _prefix suffix on functions that accept prefixes and not for functions that use keys. We could also make use of dispatch with additional types.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions