feat: support minio credentials for datasets #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Looks like CI is failing because of changes needed in test code for v2 job images. I'll try to add some commits here to fix them, but then migrate it to a separate PR so that they are grouped properly. |
Member
Author
|
Opened #108 with the updates required for v2 images |
mortenpi
reviewed
Oct 29, 2025
Member
mortenpi
left a comment
mortenpi
left a comment
There was a problem hiding this comment.
Just one small code structure request. Other than that, I think this needs:
- A changelog entry.
- A note in the docs, probably on the datasets reference page, that JuliaHub instances using Minio need at least JuliaHub.jl 0.1.16.
Handle minio credentials for dataset operations. fixes: JuliaComputing/JuliaHub#20486
Add information about MinIO backend requirements for JuliaHub datasets.
mortenpi
approved these changes
Nov 3, 2025
Member
mortenpi
left a comment
mortenpi
left a comment
There was a problem hiding this comment.
I took the liberty of editing the docs. Otherwise, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle minio credentials for dataset operations.
fixes: https://github.com/JuliaComputing/JuliaHub/issues/20486
requires: #108