perf: do not initialize _LOCAL_TZ in __init__ #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Semgrep found 1 Block-form functions should explicity return a value. If no meaningful |
![semgrep-code-juliacomputing-new[bot]](https://avatars.githubusercontent.com/u/10258468?s=60&v=4){kind=small}
pfitzseb
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
_LOCAL_TZin__init__adds a 100-200ms lag to doingusing JuliaHub. Without it, loading theJuliaHubmodule becomes effectively instantaneous.There is a theoretical behavior change here, where if you change
ENV["TZ"]at the right place, you could potentially be using a different timezone. So I added a call to_localtzin_authenticate, to ensure that we set the global as soon as the user does basically anything with JuliaHub.jl.