Skip to content

Grids of AttractorViaRecurrences unecessarily limit the number type to Float64 #98

@Datseris

Description

@Datseris

The grids used in AttractorsViaRecurrences convert all numbers to Float64. E.g., we have:

function RegularGrid(grid::NTuple)
    D = length(grid)
    grid_steps = SVector{D,Float64}(step.(grid))
    grid_maxima = SVector{D,Float64}(maximum.(grid))
    grid_minima = SVector{D,Float64}(minimum.(grid))
    return RegularGrid(grid_steps, grid_minima, grid_maxima, grid)
end

This is unecessary. We should simply extract the number type T and use vectors of type T. This can impact performance if different number types are used.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomersperformancenumeric performance and optimizing it

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions