fix show of self referential arrays (#58863)

see the tests for some MWE this fixes

closes #47280

Author: adienes

base/arrayshow.jl

@@ -488,9 +488,12 @@ function show(io::IO, X::AbstractArray)
     if !implicit
         io = IOContext(io, :typeinfo => eltype(X))
     end
-    isempty(X) ?
-        _show_empty(io, X) :
-        _show_nonempty(io, X, prefix)
+    if isempty(X)
+        return _show_empty(io, X)
+    end
+    show_circular(io, X) && return
+    recur_io = IOContext(io, :SHOWN_SET => X)
+    _show_nonempty(recur_io, X, prefix)
 end
 
 ### 0-dimensional arrays (#31481)

test/abstractarray.jl

@@ -2316,3 +2316,21 @@ end
     v2 = view(A, Base.IdentityUnitRange(1:length(A)))
     @test sum(x for x in v2) == sum(A)
 end
+
+@testset "self referential" begin
+    v = Any[1,2,3]
+    v[1] = v
+    io = IOBuffer()
+    show(io, v)
+    @test String(take!(io)) == "Any[Any[#= circular reference @-1 =#], 2, 3]"
+
+    m1 = Any[1 2; 3 4]
+    m1[1] = m1
+    show(io, m1)
+    @test String(take!(io)) == "Any[#= circular reference @-1 =# 2; 3 4]"
+
+    m2 = Any[1; 2;; 3; 4;;; 5; 6;; 7; 8]
+    m2[1] = m2
+    show(io, m2)
+    @test String(take!(io)) == "Any[#= circular reference @-1 =# 3; 2 4;;; 5 7; 6 8]"
+end