-
Notifications
You must be signed in to change notification settings - Fork 38
Add support for reverse Cuthill-McKee algorithm. #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If this is of interest, and if you are happy with the API, then I will add tests and so on. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #470 +/- ##
==========================================
+ Coverage 89.71% 89.78% +0.07%
==========================================
Files 25 27 +2
Lines 3685 3712 +27
==========================================
+ Hits 3306 3333 +27
Misses 379 379 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Maybe a more descriptive name would make sense? |
Sure! |
|
One more thing. There are actually several variants of RCM, each using a different strategy to find a pseudo-peripheral vertex. The version that I added here ( |
|
Oh if that’s the name in Matlab then we can leave it as it will be easier to discover |
|
Added tests and updated the documentation! |
|
Any issues here? @dlfivefifty |
This patch adds a function
symrcmimplementing the reverse Cuthill-McKee algorithm. It resolves this issue. The algorithm is implemented in a package extension, so there are no additional dependencies.As far as I know, there are three Julia packages that implement the reverse Cuthill-McKee algorithm; the implementation in CliqueTrees.jl is somewhat superior to the other two. Here are some benchmarks
SymRCM.jl
CuthillMcKee.jl
CliqueTrees.jl