close #596 (#597)

* close #596

Author: jverzani

Project.toml

@@ -2,7 +2,7 @@ name = "Polynomials"
 uuid = "f27b6e38-b328-58d1-80ce-0feddd5e7a45"
 license = "MIT"
 author = "JuliaMath"
-version = "4.0.16"
+version = "4.0.17"
 
 [deps]
 LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

_typos.toml

@@ -1,2 +1,3 @@
 [default.extend-words]
-Pn = "Pn"
+Pn = "Pn"
+zerod = "zerod"

src/common.jl

@@ -1347,8 +1347,11 @@ function Base.isapprox(p1::AbstractPolynomial{T,X},
     end
 end
 
-Base.isapprox(p1::AbstractPolynomial{T}, n::S;kwargs...) where {S,T} = isapprox(p1, n*one(p1))
-Base.isapprox(n::S,p1::AbstractPolynomial{T}; kwargs...) where {S,T} = isapprox(p1, n; kwargs...)
+Base.isapprox(p1::AbstractPolynomial{T}, n::S;kwargs...) where {S,T} =
+    isapprox(promote(p1, n)...; kwargs...)
+#    isapprox(p1, n*one(p1))
+Base.isapprox(n::S,p1::AbstractPolynomial{T}; kwargs...) where {S,T} =
+    isapprox(p1, n; kwargs...)
 
 Base.isapprox(::AbstractPolynomial{T}, ::Missing, args...; kwargs...) where T = missing
 Base.isapprox(::Missing, ::AbstractPolynomial{T}, args...; kwargs...) where T = missing

test/rational-functions.jl

@@ -91,6 +91,10 @@ using LinearAlgebra
     @test degree(numerator(q^2 // q)) == 0
     @test degree(denominator(q^2 // q)) == 1
 
+    # issue 596
+    p = Polynomial([0,1])
+    r = p//1
+    @test (p//1) ≈ p
 end
 
 @testset "zeros, poles, residues" begin