Skip to content

[FR] append! cannot accept collections (as would be expected from the name) #4825

@Ouroboros42

Description

@Ouroboros42

The signature of the append! method through which all others pass accepts only Real..., meaning it cannot actually add multiple datapoints to a series. It is my understanding that in Julia, append! is generally meant to be the bulk equivalent of push!, but because of this signature, append! for plots is just a less flexible version of push!.

The problematic method definition: https://github.com/JuliaPlots/Plots.jl/blob/7cd27c470e10d8364ab935935eb58a97eae55ce3/src/utils.jl#L810C1-L810C90
image

If I understand correctly, just making the type of args less restrictive, to include vectors, would fix this.
The signature of the previous method should probably also be changed for consistency but that would be a breaking change.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions