Skip to content

Commit 14f62eb

Browse files
authored
Breakage: use upload-artifact v4 (#340)
* Breakage: use upload-artifact v4 * try to make artifact names unique * try to resolve naming conflict * restore artifact path * try again * fix bug * simplify artifact names * simplify artifact names * simplify artifact names * debug * debug * debug * debug * debug * debug * improve summary table * fix summary file name
1 parent c92fb0a commit 14f62eb

File tree

2 files changed

+32
-107
lines changed

2 files changed

+32
-107
lines changed

.github/workflows/Breakage.yml

Lines changed: 32 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,17 @@ jobs:
1313
fail-fast: false
1414
matrix:
1515
pkg: [
16-
"JuliaSmoothOptimizers/CaNNOLeS.jl",
17-
"JuliaSmoothOptimizers/DCISolver.jl",
18-
"JuliaSmoothOptimizers/FletcherPenaltySolver.jl",
19-
"JuliaSmoothOptimizers/JSOSolvers.jl",
20-
"JuliaSmoothOptimizers/Krylov.jl",
21-
"JuliaSmoothOptimizers/NLPModels.jl",
22-
"JuliaSmoothOptimizers/NLPModelsModifiers.jl",
23-
"JuliaSmoothOptimizers/Percival.jl",
24-
"JuliaSmoothOptimizers/PROPACK.jl",
25-
"JuliaSmoothOptimizers/QuadraticModels.jl",
26-
"JuliaSmoothOptimizers/SolverTools.jl"
16+
"CaNNOLeS.jl",
17+
"DCISolver.jl",
18+
"FletcherPenaltySolver.jl",
19+
"JSOSolvers.jl",
20+
"Krylov.jl",
21+
"NLPModels.jl",
22+
"NLPModelsModifiers.jl",
23+
"Percival.jl",
24+
"PROPACK.jl",
25+
"QuadraticModels.jl",
26+
"SolverTools.jl"
2727
]
2828
pkgversion: [latest, stable]
2929

@@ -50,14 +50,13 @@ jobs:
5050
# Breakage test
5151
- name: 'Breakage of ${{ matrix.pkg }}, ${{ matrix.pkgversion }} version'
5252
env:
53-
URL: ${{ matrix.pkg }}
53+
PKG: ${{ matrix.pkg }}
5454
VERSION: ${{ matrix.pkgversion }}
5555
run: |
5656
set -v
57-
mkdir -p ./pr
58-
echo "${{ github.event.number }}" > ./pr/NR
59-
git clone https://github.com/$URL
60-
export PKG=$(echo $URL | cut -f2 -d/)
57+
mkdir -p ./breakage
58+
# echo "${{ github.event.number }}" > ./breakage-$PKG-$VERSION/NR
59+
git clone https://github.com/JuliaSmoothOptimizers/$PKG
6160
cd $PKG
6261
if [ $VERSION == "stable" ]; then
6362
TAG=$(git tag -l "v*" --sort=-creatordate | head -n1)
@@ -73,7 +72,7 @@ jobs:
7372
julia -e 'using Pkg;
7473
PKG, TAG, VERSION = ENV["PKG"], ENV["TAG"], ENV["VERSION"]
7574
joburl = joinpath(ENV["GITHUB_SERVER_URL"], ENV["GITHUB_REPOSITORY"], "actions/runs", ENV["GITHUB_RUN_ID"])
76-
open("../pr/$PKG-$VERSION", "w") do io
75+
open("../breakage/breakage-$PKG-$VERSION", "w") do io
7776
try
7877
TAG == "no_tag" && error("Not tag for $VERSION")
7978
pkg"activate .";
@@ -92,34 +91,34 @@ jobs:
9291
end;
9392
end'
9493
95-
- uses: actions/upload-artifact@v2
94+
- uses: actions/upload-artifact@v4
9695
with:
97-
name: pr
98-
path: pr/
96+
name: breakage-${{ matrix.pkg }}-${{ matrix.pkgversion }}
97+
path: breakage/breakage-*
9998

10099
upload:
101100
needs: break
102101
runs-on: ubuntu-latest
103102
steps:
104103
- uses: actions/checkout@v2
105104

106-
- uses: actions/download-artifact@v2
105+
- uses: actions/download-artifact@v4
107106
with:
108-
name: pr
109-
path: pr/
107+
path: breakage
108+
pattern: breakage-*
109+
merge-multiple: true
110110

111-
- run: ls
111+
- run: ls -R
112112
- run: |
113-
cd pr
114-
echo "| Package name | latest | stable |" > MSG
115-
echo "|--|--|--|" >> MSG
113+
cd breakage
114+
echo "| Package name | latest | stable |" > ../summary.md
115+
echo "|--|--|--|" >> ../summary.md
116116
count=0
117117
for file in *
118118
do
119-
[ "$file" == "NR" ] && continue
120119
[ "$file" == "MSG" ] && continue
121120
if [ $count == "0" ]; then
122-
name=$(echo $file | cut -f1 -d-)
121+
name=$(echo $file | cut -f2 -d-)
123122
echo -n "| $name | "
124123
else
125124
echo -n "| "
@@ -132,9 +131,9 @@ jobs:
132131
echo " |"
133132
count=0
134133
fi
135-
done >> MSG
134+
done >> ../summary.md
136135
137-
- uses: actions/upload-artifact@v2
136+
- name: PR comment with file
137+
uses: thollander/actions-comment-pull-request@v2
138138
with:
139-
name: pr
140-
path: pr/
139+
filePath: summary.md

.github/workflows/CommentPR.yml

Lines changed: 0 additions & 74 deletions
This file was deleted.

0 commit comments

Comments
 (0)