remove deprecated hide_progress and use_threads kwargs

Author: palday

NEWS.md

@@ -3,6 +3,8 @@ MixedModels v5.0.0 Release Notes
 - Optimization is now performed _without constraints_. In a post-fitting step, the the Cholesky factor is canonicalized to have non-negative diagonal elements. [#840]
 - The default optimizer has changed to NLopt's implementation of NEWUOA where possible. NLopt's implementation fails on 1-dimensional problems, so in the case A single, scalar random effect, BOBYQA is used instead. In the future, the default optimizer backend will likely change to PRIMA and NLopt support will be moved to an extension. Blocking this change in backend is an issue with PRIMA.jl when running in VSCode's built-in REPL on Linux. [#840]
 - [BREAKING] Support for constrained optimization has been completely removed, i.e. the field `lowerbd` has been removed from `OptSummary`.
+- [BREAKING] The deprecated `use_threads` kwarg has been dropped from `parametricbootstrap`. It had been a no-op since v4.10.0. [#841]
+- [BREAKING] The deprecated `hide_progress` kwarg has been dropped from `parametricbootstrap`. It had been replaced by `progress` since v4.22.0. [#841]
 
 
 MixedModels v4.38.0 Release Notes

src/bootstrap.jl

@@ -217,18 +217,9 @@ function parametricbootstrap(
     β::AbstractVector=fixef(morig),
     σ=morig.σ,
     θ::AbstractVector=morig.θ,
-    use_threads::Bool=false,
     progress::Bool=true,
-    hide_progress::Union{Bool,Nothing}=nothing,
     optsum_overrides=(;),
 ) where {T}
-    if !isnothing(hide_progress)
-        Base.depwarn(
-            "`hide_progress` is deprecated, please use `progress` instead." *
-            "NB: `progress` is a positive action, i.e. `progress=true` means show the progress bar.",
-            :parametricbootstrap; force=true)
-        progress = !hide_progress
-    end
     if σ !== missing
         σ = T(σ)
     end
@@ -248,10 +239,6 @@ function parametricbootstrap(
 
     β_names = Tuple(Symbol.(coefnames(morig)))
 
-    use_threads && Base.depwarn(
-        "use_threads is deprecated and will be removed in a future release",
-        :parametricbootstrap,
-    )
     samp = replicate(n; progress) do
         simulate!(rng, m; β, σ, θ)
         refit!(m; progress=false, fitlog=false)

src/utilities.jl

@@ -129,19 +129,8 @@ Return a vector of the values of `n` calls to `f()` - used in simulations where
 bar is automatically disabled for non-interactive (i.e. logging) contexts.
 """
 function replicate(
-    f::Function, n::Integer; use_threads=false, hide_progress=nothing, progress=true
+    f::Function, n::Integer; progress=true
 )
-    use_threads && Base.depwarn(
-        "use_threads is deprecated and will be removed in a future release",
-        :replicate,
-    )
-    if !isnothing(hide_progress)
-        Base.depwarn(
-            "`hide_progress` is deprecated, please use `progress` instead." *
-            "NB: `progress` is a positive action, i.e. `progress=true` means show the progress bar.",
-            :replicate; force=true)
-        progress = !hide_progress
-    end
     # and we want some advanced options
     p = Progress(n; output=Base.stderr, enabled=progress && !_is_logging(stderr))
     # get the type

test/bootstrap.jl

@@ -15,7 +15,7 @@ include("modelcache.jl")
 
 function quickboot(m, n=2)
     return parametricbootstrap(MersenneTwister(42), n, m;
-        progress=false, use_threads=false,
+        progress=false,
         optsum_overrides=(; ftol_rel=1e-8))
 end
 
@@ -91,11 +91,8 @@ end
     # two implicit tests
     # 1. type conversion of ints to floats
     # 2. test method for default RNG
-    @test_logs((:warn, r"hide_progress"),
-        parametricbootstrap(1, fm, β=[1], σ=1, hide_progress=true))
-
     bsamp = parametricbootstrap(MersenneTwister(1234321), 100, fm;
-        use_threads=false, progress=false)
+        progress=false)
     @test isa(propertynames(bsamp), Vector{Symbol})
     @test length(bsamp.objective) == 100
     @test keys(first(bsamp.fits)) == (:objective, :σ, :β, :se, :θ)
@@ -106,13 +103,13 @@ end
 
     @testset "optsum_overrides" begin
         bsamp2 = parametricbootstrap(MersenneTwister(1234321), 100, fm;
-            use_threads=false, progress=false,
+            progress=false,
             optsum_overrides=(; ftol_rel=1e-8))
         # for such a simple, small model setting the function value
         # tolerance has little effect until we do something extreme
         @test bsamp.objective ≈ bsamp2.objective
         bsamp2 = parametricbootstrap(MersenneTwister(1234321), 100, fm;
-            use_threads=false, progress=false,
+            progress=false,
             optsum_overrides=(; ftol_rel=1.0))
         @test !(bsamp.objective ≈ bsamp2.objective)
     end
@@ -130,12 +127,6 @@ end
     @test only(unique(coefp.coefname)) == Symbol("(Intercept)")
     @test propertynames(coefp) == [:iter, :coefname, :β, :se, :z, :p]
 
-    @testset "threaded bootstrap" begin
-        @test_logs (:warn, r"use_threads is deprecated") parametricbootstrap(
-            MersenneTwister(1234321), 1, fm;
-            use_threads=true, progress=false)
-    end
-
     @testset "zerocorr + Base.length + ftype" begin
         fmzc = models(:sleepstudy)[2]
         pbzc = parametricbootstrap(MersenneTwister(42), 5, fmzc, Float16;

test/utilities.jl

@@ -39,11 +39,6 @@ end
     @test isconstant(Union{Int,Missing}[missing, missing, missing])
 end
 
-@testset "replicate" begin
-    @test_logs (:warn, r"use_threads is deprecated") replicate(string, 1; use_threads=true)
-    @test_logs (:warn, r"hide_progress") replicate(string, 1; hide_progress=true)
-end
-
 @testset "datasets" begin
     @test isa(MixedModels.datasets(), Vector{String})
     @test length(MixedModels.dataset(:dyestuff)) == 2