Skip to content
This repository was archived by the owner on Dec 17, 2024. It is now read-only.
This repository was archived by the owner on Dec 17, 2024. It is now read-only.

Asciinema player not respecting autoPlay #94

Open
#95
Open
Asciinema player not respecting autoPlay#94
#95
@tomups

Description

@tomups
tomups
opened on May 1, 2024

I see you are using an intersection observer to auto play and pause the asciinema player:

web-garden/components/TerminalPlayer/TerminalPlayer.astro

Lines 66 to 78 in 2ab3ccd

const observer = new IntersectionObserver((entries) => {
entries.forEach((entry) => {
const player = players.get(entry.target);
if (player) {
if (entry.isIntersecting) {
player.play();
} else {
player.pause();
}
}
});
}, options);

It's a nice to have, but unfortunately as it's not configurable, it's like if the autoPlay setting of asciinema is always true.

It would be great if this play-on-view setting was configurable as well and not enabled by default, as in my case I prefer users to start the recording manually.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions