add ssh settings page

you can edit you devices, copy your ssh key and select you ssh binary on
this page
device are stored directly in a KConfigGroup, the deviceList property of
Settings is only there to pass the devices around to other widgets

Author: lievenhey

src/recordhost.h

@@ -14,6 +14,7 @@
 enum class RecordType
 {
     LaunchApplication,
+    LaunchRemoteApplication,
     AttachToProcess,
     ProfileSystem,
     NUM_RECORD_TYPES

src/settings.cpp

@@ -230,6 +230,14 @@ void Settings::loadFromFile()
     connect(this, &Settings::lastUsedEnvironmentChanged, this, [sharedConfig](const QString& envName) {
         sharedConfig->group("PerfPaths").writeEntry("lastUsed", envName);
     });
+
+    setSSHPath(sharedConfig->group("SSH").readEntry("ssh"));
+    setSSHCopyKeyPath(sharedConfig->group("SSH").readEntry("ssh-copy-id"));
+
+    connect(this, &Settings::sshPathChanged, this,
+            [sharedConfig](const QString& path) { sharedConfig->group("SSH").writeEntry("ssh", path); });
+    connect(this, &Settings::sshCopyIdPathChanged, this,
+            [sharedConfig](const QString& path) { sharedConfig->group("SSH").writeEntry("ssh-copy-id", path); });
 }
 
 void Settings::setSourceCodePaths(const QString& paths)
@@ -247,3 +255,27 @@ void Settings::setPerfPath(const QString& path)
         emit perfPathChanged(m_perfPath);
     }
 }
+
+void Settings::setSSHPath(const QString& sshPath)
+{
+    if (m_sshPath != sshPath) {
+        m_sshPath = sshPath;
+        emit sshPathChanged(m_sshPath);
+    }
+}
+
+void Settings::setSSHCopyKeyPath(const QString& sshCopyIdPath)
+{
+    if (m_sshCopyIdPath != sshCopyIdPath) {
+        m_sshCopyIdPath = sshCopyIdPath;
+        emit sshCopyIdPathChanged(m_sshCopyIdPath);
+    }
+}
+
+void Settings::setDevices(const QStringList& devices)
+{
+    if (m_devices != devices) {
+        m_devices = devices;
+        emit devicesChanged(m_devices);
+    }
+}

src/settings.h

@@ -149,6 +149,21 @@ class Settings : public QObject
         return m_perfPath;
     }
 
+    QString sshPath() const
+    {
+        return m_sshPath;
+    }
+
+    QString sshCopyIdPath() const
+    {
+        return m_sshCopyIdPath;
+    }
+
+    QStringList devices() const
+    {
+        return m_devices;
+    }
+
     void loadFromFile();
 
 signals:
@@ -170,6 +185,9 @@ class Settings : public QObject
     void lastUsedEnvironmentChanged(const QString& envName);
     void sourceCodePathsChanged(const QString& paths);
     void perfPathChanged(const QString& perfPath);
+    void sshPathChanged(const QString& sshPath);
+    void sshCopyIdPathChanged(const QString& sshCopyIdPath);
+    void devicesChanged(const QStringList& devices);
 
 public slots:
     void setPrettifySymbols(bool prettifySymbols);
@@ -192,6 +210,9 @@ public slots:
     void setLastUsedEnvironment(const QString& envName);
     void setSourceCodePaths(const QString& paths);
     void setPerfPath(const QString& path);
+    void setSSHPath(const QString& path);
+    void setSSHCopyKeyPath(const QString& path);
+    void setDevices(const QStringList& devices);
 
 private:
     Settings() = default;
@@ -223,4 +244,8 @@ public slots:
     QColor m_callgraphColor;
 
     QString m_perfPath;
+    QString m_sshPath;
+    QString m_sshCopyIdPath;
+
+    QStringList m_devices;
 };

src/settingsdialog.cpp

@@ -13,6 +13,7 @@
 #include "ui_flamegraphsettingspage.h"
 #include "ui_perfsettingspage.h"
 #include "ui_sourcepathsettings.h"
+#include "ui_sshsettingspage.h"
 #include "ui_unwindsettingspage.h"
 
 #include "multiconfigwidget.h"
@@ -26,6 +27,7 @@
 #include <QKeyEvent>
 #include <QLineEdit>
 #include <QListView>
+#include <QProcess>
 
 #include <hotspot-config.h>
 
@@ -63,6 +65,7 @@ SettingsDialog::SettingsDialog(QWidget* parent)
 #if KGraphViewerPart_FOUND
     , callgraphPage(new Ui::CallgraphSettingsPage)
 #endif
+    , sshSettingsPage(new Ui::SSHSettingsPage)
 {
     addPerfSettingsPage();
     addPathSettingsPage();
@@ -72,6 +75,7 @@ SettingsDialog::SettingsDialog(QWidget* parent)
     addCallgraphPage();
 #endif
     addSourcePathPage();
+    addSSHPage();
 }
 
 SettingsDialog::~SettingsDialog() = default;
@@ -262,3 +266,73 @@ void SettingsDialog::addSourcePathPage()
         Settings::instance()->setSourceCodePaths(sourcePathPage->sourcePaths->items().join(colon));
     });
 }
+
+void SettingsDialog::addSSHPage()
+{
+    auto page = new QWidget(this);
+    auto item = addPage(page, tr("SSH Settings"));
+    item->setHeader(tr("SSH Settings Page"));
+    item->setIcon(QIcon::fromTheme(QStringLiteral("preferences-system-windows-behavior")));
+    sshSettingsPage->setupUi(page);
+    sshSettingsPage->messageWidget->hide();
+    sshSettingsPage->errorWidget->hide();
+
+    auto configGroup = KSharedConfig::openConfig()->group("SSH");
+    sshSettingsPage->deviceConfig->setChildWidget(
+        sshSettingsPage->deviceSettings,
+        {sshSettingsPage->username, sshSettingsPage->hostname, sshSettingsPage->options});
+    sshSettingsPage->deviceConfig->setConfigGroup(configGroup);
+
+    connect(sshSettingsPage->copySshKeyButton, &QPushButton::pressed, this, [this] {
+        auto* copyKey = new QProcess(this);
+
+        auto path = sshSettingsPage->sshCopyIdPath->text();
+        if (path.isEmpty()) {
+            path = QStandardPaths::findExecutable(QStringLiteral("ssh-copy-id"));
+        }
+        if (path.isEmpty()) {
+            sshSettingsPage->messageWidget->setText(tr("Could not find ssh-copy-id"));
+            sshSettingsPage->messageWidget->show();
+            return;
+        }
+
+        if (qEnvironmentVariableIsSet("SSH_ASKPASS")) {
+            auto env = QProcessEnvironment::systemEnvironment();
+            env.insert(QStringLiteral("SSH_ASKPASS"), QString::fromUtf8(qgetenv("SSH_ASKPASS")));
+            copyKey->setProcessEnvironment(env);
+        }
+
+        copyKey->setProgram(path);
+
+        QStringList arguments = {};
+        auto options = sshSettingsPage->options->text();
+        if (!options.isEmpty()) {
+            arguments.append(options.split(QLatin1Char(' ')));
+        }
+        arguments.append(
+            QStringLiteral("%1@%2").arg(sshSettingsPage->username->text(), sshSettingsPage->hostname->text()));
+        copyKey->setArguments(arguments);
+
+        connect(copyKey, qOverload<int, QProcess::ExitStatus>(&QProcess::finished), this,
+                [this, copyKey](int code, QProcess::ExitStatus) {
+                    if (code == 0) {
+                        sshSettingsPage->messageWidget->setText(QStringLiteral("Copy key successfully"));
+                        sshSettingsPage->messageWidget->show();
+                    } else {
+                        sshSettingsPage->errorWidget->setText(QStringLiteral("Failed to copy key"));
+                        sshSettingsPage->errorWidget->show();
+                    }
+                    copyKey->deleteLater();
+                });
+        copyKey->start();
+    });
+
+    connect(buttonBox(), &QDialogButtonBox::accepted, this, [this, configGroup] {
+        sshSettingsPage->deviceConfig->saveCurrentConfig();
+
+        auto settings = Settings::instance();
+        settings->setDevices(configGroup.groupList());
+        settings->setSSHPath(sshSettingsPage->sshBinary->text());
+        settings->setSSHCopyKeyPath(sshSettingsPage->sshCopyIdPath->text());
+    });
+}

src/settingsdialog.h

@@ -19,6 +19,7 @@ class DebuginfodPage;
 class CallgraphSettingsPage;
 class SourcePathSettingsPage;
 class PerfSettingsPage;
+class SSHSettingsPage;
 }
 
 class MultiConfigWidget;
@@ -50,11 +51,13 @@ class SettingsDialog : public KPageDialog
     void addDebuginfodPage();
     void addCallgraphPage();
     void addSourcePathPage();
+    void addSSHPage();
 
     std::unique_ptr<Ui::PerfSettingsPage> perfPage;
     std::unique_ptr<Ui::UnwindSettingsPage> unwindPage;
     std::unique_ptr<Ui::FlamegraphSettingsPage> flamegraphPage;
     std::unique_ptr<Ui::DebuginfodPage> debuginfodPage;
     std::unique_ptr<Ui::SourcePathSettingsPage> sourcePathPage;
     std::unique_ptr<Ui::CallgraphSettingsPage> callgraphPage;
+    std::unique_ptr<Ui::SSHSettingsPage> sshSettingsPage;
 };