Create one message if length is too short and a different message if too long

[Pi-Cla]

When I tried to update past 0.16 I now have a "Duplicate field length" bug when I try to use duplicate fields like so:

#[validate(
        length(min = 1, message = "cannot be empty"),
        length(max = 32, message = "must be <= 32 characters")
    )]
    pub name: String,

where I intentionally use two different length checks to create two different messages.

Is there a way to still create two different messages or will I have to just combine them into one message like: "string was empty or had more than 32 characters"?

[Keats]

The messages should be dynamic depending on whether min/max/equal are set really

[kuskhan]

I think this is a very critical issue. Many developers are still using version 0.16.1 for this reason.

[Keats]

I would take a PR to fix multiple validators, I haven't had the time to get to that.

[kuskhan]

@Keats @Pi-Cla
Sorry for the delayed response. Actually, I have been using a customised version that allows multiple validations for length. It has worked without any issues. However, I realised that to make it usable for everyone, I would need to add additional logic to handle errors when min, max, or equal are repeated multiple times. This made me think that the code might becomes increasingly complex.

Therefore, I suggest keeping the current approach of not allowing duplicated in length validation and adding min_message and max_message fields to override error messages. This way, the code would be more concise, and unnecessary duplicate validation could be avoided.

Please pick the option that you think is better, and I will attempt to implement it and submit a PR.

Suggestion A:

#[validate(
    length(min = 1, message = "Password is required"),
    length(max = 8, message = "Password must be 8 characters or fewer")
)]

Suggestion B:

#[validate(
    length(min = 1, max = 8, 
    min_message = "Password is required", 
    max_message = "Password must be 8 characters or fewer"),
)]

[Pi-Cla]

Either way works for me

[Keats]

I'd prefer A so it's more consistent with the other validators, and you'd need min_code etc with B

[kuskhan]

Sorry. My solution, where I created the type of length token as Vec<Length>, works well, but when running tests in the test module, if multiple lengths are used, the resulting type becomes {unknown}. As a result, IDE auto-suggestion does not work when trying to call .validate() in the test module.

I will do some further research to resolve the issue and then submit a PR.