Skip to content

Commit d1a91d7

Browse files
authored
Release 1.1 merge to main (#17)
* Add CName support (#15)
1 parent 0e06724 commit d1a91d7

File tree

6 files changed

+57
-52
lines changed

6 files changed

+57
-52
lines changed
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
name: Keyfactor Bootstrap Workflow
2+
3+
on:
4+
workflow_dispatch:
5+
pull_request:
6+
types: [opened, closed, synchronize, edited, reopened]
7+
push:
8+
create:
9+
branches:
10+
- 'release-*.*'
11+
12+
jobs:
13+
call-starter-workflow:
14+
uses: keyfactor/actions/.github/workflows/starter.yml@v2
15+
secrets:
16+
token: ${{ secrets.V2BUILDTOKEN}}
17+
APPROVE_README_PUSH: ${{ secrets.APPROVE_README_PUSH}}
18+
gpg_key: ${{ secrets.KF_GPG_PRIVATE_KEY }}
19+
gpg_pass: ${{ secrets.KF_GPG_PASSPHRASE }}

.github/workflows/keyfactor-starter-workflow.yml

Lines changed: 0 additions & 42 deletions
This file was deleted.

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
2+
v1.1.0
3+
- Add Support for CNAME Domain Validation
4+
15
v1.0.10
26
- Sync Issue where Sync only works after service restart fixed
37
- Sync Fix when errors occur in the CSC Api so next sync works

CscGlobalCaProxy/RequestManager.cs

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,20 @@ public DomainControlValidation GetDomainControlValidation(string methodType, str
108108
};
109109
}
110110

111+
112+
public static Func<string, string> Pemify = ss =>
113+
ss.Length <= 64 ? ss : ss.Substring(0, 64) + "\n" + Pemify(ss.Substring(64));
114+
111115
public RegistrationRequest GetRegistrationRequest(EnrollmentProductInfo productInfo, string csr,
112116
Dictionary<string, string[]> sans)
113117
{
114-
var bytes = Encoding.UTF8.GetBytes(csr);
118+
119+
var cert = "-----BEGIN CERTIFICATE REQUEST-----\r\n";
120+
cert = cert + Pemify(csr);
121+
cert = cert + "\r\n-----END CERTIFICATE REQUEST-----";
122+
123+
124+
var bytes = Encoding.UTF8.GetBytes(cert);
115125
var encodedString = Convert.ToBase64String(bytes);
116126
var commonNameValidationEmail = productInfo.ProductParameters["CN DCV Email (admin@yourdomain.com)"];
117127
var methodType = productInfo.ProductParameters["Domain Control Validation Method"];
@@ -174,7 +184,11 @@ public Notifications GetNotifications(EnrollmentProductInfo productInfo)
174184
public RenewalRequest GetRenewalRequest(EnrollmentProductInfo productInfo, string uUId, string csr,
175185
Dictionary<string, string[]> sans)
176186
{
177-
var bytes = Encoding.UTF8.GetBytes(csr);
187+
var cert = "-----BEGIN CERTIFICATE REQUEST-----\r\n";
188+
cert = cert + Pemify(csr);
189+
cert = cert + "\r\n-----END CERTIFICATE REQUEST-----";
190+
191+
var bytes = Encoding.UTF8.GetBytes(cert);
178192
var encodedString = Convert.ToBase64String(bytes);
179193
var commonNameValidationEmail = productInfo.ProductParameters["CN DCV Email (admin@yourdomain.com)"];
180194
var methodType = productInfo.ProductParameters["Domain Control Validation Method"];
@@ -228,7 +242,11 @@ private List<SubjectAlternativeName> GetSubjectAlternativeNames(EnrollmentProduc
228242
public ReissueRequest GetReissueRequest(EnrollmentProductInfo productInfo, string uUId, string csr,
229243
Dictionary<string, string[]> sans)
230244
{
231-
var bytes = Encoding.UTF8.GetBytes(csr);
245+
var cert = "-----BEGIN CERTIFICATE REQUEST-----\r\n";
246+
cert = cert + Pemify(csr);
247+
cert = cert + "\r\n-----END CERTIFICATE REQUEST-----";
248+
249+
var bytes = Encoding.UTF8.GetBytes(cert);
232250
var encodedString = Convert.ToBase64String(bytes);
233251
var commonNameValidationEmail = productInfo.ProductParameters["CN DCV Email (admin@yourdomain.com)"];
234252
var methodType = productInfo.ProductParameters["Domain Control Validation Method"];

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@ Csc Global operates a PKI as a service platform for customers around the globe.
1010
This repository contains an AnyGateway CA Connector, which is a plugin to the Keyfactor AnyGateway. AnyGateway CA Connectors allow Keyfactor Command to be used for inventory, issuance, and revocation of certificates from a third-party certificate authority.
1111

1212

13+
## Support for CSC Global
1314

15+
CSC Global is supported by Keyfactor for Keyfactor customers. If you have a support issue, please open a support ticket via the Keyfactor Support Portal at https://support.keyfactor.com
16+
17+
###### To report a problem or suggest a new feature, use the **[Issues](../../issues)** tab. If you want to contribute actual bug fixes or proposed enhancements, use the **[Pull requests](../../pulls)** tab.
1418

1519

1620
---

integration-manifest.json

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
{
2-
"$schema": "https://keyfactor.github.io/integration-manifest-schema.json",
3-
"integration_type": "ca-gateway",
4-
"name": "CSC Global",
5-
"status": "production",
6-
"description": "Csc Global operates a PKI as a service platform for customers around the globe. The AnyGateway solution for CscGlobal is designed to allow Keyfactor Command the ability to: - Sync certificates issued from the CA - Request new certificates from the CA - Revoke certificates directly from Keyfactor Command",
7-
"link_github": true,
8-
"update_catalog": true
2+
"$schema": "https://keyfactor.github.io/integration-manifest-schema.json",
3+
"integration_type": "ca-gateway",
4+
"name": "CSC Global",
5+
"status": "production",
6+
"description": "Csc Global operates a PKI as a service platform for customers around the globe. The AnyGateway solution for CscGlobal is designed to allow Keyfactor Command the ability to: - Sync certificates issued from the CA - Request new certificates from the CA - Revoke certificates directly from Keyfactor Command",
7+
"link_github": true,
8+
"update_catalog": true,
9+
"support_level": "kf-supported",
10+
"release_dir": "CscGlobalCaProxy/bin/Release"
911
}

0 commit comments

Comments
 (0)