Skip to content

Commit 792c13f

Browse files
committed
chore: remove useless dependencies rand & strum_macros & tracing
1 parent 93874f6 commit 792c13f

File tree

5 files changed

+58
-14
lines changed

5 files changed

+58
-14
lines changed

Cargo.toml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,14 @@ ordered-float = { version = "4" }
4646
paste = { version = "1" }
4747
parking_lot = { version = "0.12", features = ["arc_lock"] }
4848
petgraph = { version = "0.6" }
49-
rand = { version = "0.9.0-alpha" }
5049
regex = { version = "1" }
51-
rocksdb = { version = "0.22.0" }
50+
rocksdb = { version = "0.22" }
5251
rust_decimal = { version = "1" }
5352
serde = { version = "1", features = ["derive", "rc"] }
5453
fnck_sql_serde_macros = { version = "0.1.0", path = "fnck_sql_serde_macros" }
5554
siphasher = { version = "1", features = ["serde"] }
5655
sqlparser = { version = "0.34", features = ["serde"] }
57-
strum_macros = { version = "0.26.2" }
5856
thiserror = { version = "1" }
59-
tracing = { version = "0.1" }
6057
typetag = { version = "0.2" }
6158
ulid = { version = "1", features = ["serde"] }
6259

src/lib.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@
9393
#![feature(iterator_try_collect)]
9494
#![feature(slice_pattern)]
9595
#![feature(stmt_expr_attributes)]
96+
#![feature(random)]
9697
extern crate core;
9798

9899
pub mod binder;

src/optimizer/core/cm_sketch.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,12 @@ use crate::expression::range_detacher::Range;
33
use crate::serdes::{ReferenceSerialization, ReferenceTables};
44
use crate::storage::{TableCache, Transaction};
55
use crate::types::value::DataValue;
6-
use rand::RngCore;
76
use siphasher::sip::SipHasher13;
87
use std::borrow::Borrow;
98
use std::hash::{Hash, Hasher};
109
use std::io::{Read, Write};
1110
use std::marker::PhantomData;
11+
use std::random::random;
1212
use std::{cmp, mem};
1313

1414
pub(crate) type FastHasher = SipHasher13;
@@ -138,8 +138,7 @@ impl<K: Hash> CountMinSketch<K> {
138138
}
139139

140140
fn sip_new() -> FastHasher {
141-
let mut rng = rand::thread_rng();
142-
FastHasher::new_with_keys(rng.next_u64(), rng.next_u64())
141+
FastHasher::new_with_keys(random(), random())
143142
}
144143

145144
fn offset<Q: ?Sized + Hash>(&self, hashes: &mut [u64; 2], key: &Q, k_i: usize) -> usize

src/planner/operator/join.rs

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,8 @@ use fnck_sql_serde_macros::ReferenceSerialization;
55
use itertools::Itertools;
66
use std::fmt;
77
use std::fmt::Formatter;
8-
use strum_macros::Display;
98

10-
#[derive(
11-
Debug, Display, PartialEq, Eq, Clone, Copy, Hash, Ord, PartialOrd, ReferenceSerialization,
12-
)]
9+
#[derive(Debug, PartialEq, Eq, Clone, Copy, Hash, Ord, PartialOrd, ReferenceSerialization)]
1310
pub enum JoinType {
1411
Inner,
1512
LeftOuter,
@@ -50,6 +47,22 @@ impl JoinOperator {
5047
}
5148
}
5249

50+
impl fmt::Display for JoinType {
51+
fn fmt(&self, f: &mut Formatter) -> fmt::Result {
52+
match self {
53+
JoinType::Inner => write!(f, "Inner")?,
54+
JoinType::LeftOuter => write!(f, "LeftOuter")?,
55+
JoinType::LeftSemi => write!(f, "LeftSemi")?,
56+
JoinType::LeftAnti => write!(f, "LeftAnti")?,
57+
JoinType::RightOuter => write!(f, "RightOuter")?,
58+
JoinType::Full => write!(f, "Full")?,
59+
JoinType::Cross => write!(f, "Cross")?,
60+
}
61+
62+
Ok(())
63+
}
64+
}
65+
5366
impl fmt::Display for JoinOperator {
5467
fn fmt(&self, f: &mut Formatter) -> fmt::Result {
5568
write!(f, "{} Join{}", self.join_type, self.on)?;

src/types/mod.rs

Lines changed: 37 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ use std::cmp;
1313
use crate::errors::DatabaseError;
1414
use fnck_sql_serde_macros::ReferenceSerialization;
1515
use sqlparser::ast::{CharLengthUnits, ExactNumberInfo, TimezoneInfo};
16-
use strum_macros::AsRefStr;
1716
use ulid::Ulid;
1817

1918
pub type ColumnId = Ulid;
@@ -28,7 +27,6 @@ pub type ColumnId = Ulid;
2827
Hash,
2928
PartialOrd,
3029
Ord,
31-
AsRefStr,
3230
Serialize,
3331
Deserialize,
3432
ReferenceSerialization,
@@ -449,7 +447,43 @@ impl TryFrom<sqlparser::ast::DataType> for LogicalType {
449447

450448
impl std::fmt::Display for LogicalType {
451449
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
452-
write!(f, "{}", self.as_ref().to_uppercase())
450+
match self {
451+
LogicalType::Invalid => write!(f, "Invalid")?,
452+
LogicalType::SqlNull => write!(f, "SqlNull")?,
453+
LogicalType::Boolean => write!(f, "Boolean")?,
454+
LogicalType::Tinyint => write!(f, "Tinyint")?,
455+
LogicalType::UTinyint => write!(f, "UTinyint")?,
456+
LogicalType::Smallint => write!(f, "Smallint")?,
457+
LogicalType::USmallint => write!(f, "USmallint")?,
458+
LogicalType::Integer => write!(f, "Integer")?,
459+
LogicalType::UInteger => write!(f, "UInteger")?,
460+
LogicalType::Bigint => write!(f, "Bigint")?,
461+
LogicalType::UBigint => write!(f, "UBigint")?,
462+
LogicalType::Float => write!(f, "Float")?,
463+
LogicalType::Double => write!(f, "Double")?,
464+
LogicalType::Char(len, units) => write!(f, "Char({}, {})", len, units)?,
465+
LogicalType::Varchar(len, units) => write!(f, "Varchar({:?}, {})", len, units)?,
466+
LogicalType::Date => write!(f, "Date")?,
467+
LogicalType::DateTime => write!(f, "DateTime")?,
468+
LogicalType::Time => write!(f, "Time")?,
469+
LogicalType::Decimal(precision, scale) => {
470+
write!(f, "Decimal({:?}, {:?})", precision, scale)?
471+
}
472+
LogicalType::Tuple(types) => {
473+
write!(f, "(")?;
474+
let mut first = true;
475+
for ty in types {
476+
if !first {
477+
write!(f, ", ")?;
478+
}
479+
first = false;
480+
write!(f, "{}", ty)?;
481+
}
482+
write!(f, ")")?
483+
}
484+
}
485+
486+
Ok(())
453487
}
454488
}
455489

0 commit comments

Comments
 (0)