Skip to content

Commit 835f0be

Browse files
author
Marc Littlemore
committed
Refactoring
1 parent 7f10f84 commit 835f0be

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

src/AmazonAPI.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ private function AddError($error) {
127127
array_push($this->mErrors, $error);
128128
}
129129

130-
private function MakeSignedRequest($params) {
130+
private function MakeAndParseRequest($params) {
131131
$signedUrl = $this->urlBuilder->generate($params);
132132

133133
try {
@@ -141,13 +141,8 @@ private function MakeSignedRequest($params) {
141141
$this->AddError("Error downloading data : $signedUrl : " . $error->getMessage());
142142
}
143143

144-
return false;
145-
}
146-
147-
private function MakeAndParseRequest($params) {
148-
$parsedXml = $this->MakeSignedRequest($params);
149144
if ($parsedXml === false) {
150-
return(false);
145+
return false;
151146
}
152147

153148
return $this->dataTransformer->execute($parsedXml);

0 commit comments

Comments
 (0)