Skip to content

Commit e618827

Browse files
authored
Merge pull request #258 from MerginMaps/fix-logs-sending
Fix logs sending
2 parents 5bec292 + 6dd35cd commit e618827

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

mergin/client.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -273,8 +273,10 @@ def get(self, path, data=None, headers={}, validate_auth=True):
273273
request = urllib.request.Request(url, headers=headers)
274274
return self._do_request(request, validate_auth=validate_auth)
275275

276-
def post(self, path, data=None, headers={}, validate_auth=True):
276+
def post(self, path, data=None, headers={}, validate_auth=True, query_params: dict[str, str] = None):
277277
url = urllib.parse.urljoin(self.url, urllib.parse.quote(path))
278+
if query_params:
279+
url += "?" + urllib.parse.urlencode(query_params)
278280
if headers.get("Content-Type", None) == "application/json":
279281
data = json.dumps(data, cls=DateTimeEncoder).encode("utf-8")
280282
request = urllib.request.Request(url, data, headers, method="POST")
@@ -1420,7 +1422,7 @@ def send_logs(
14201422
if is_version_acceptable(self.server_version(), "2025.4.1") and (
14211423
diagnostic_logs_url is None or diagnostic_logs_url == ""
14221424
):
1423-
url = "v2/diagnostic-logs" + "?" + urllib.parse.urlencode(params)
1425+
url = "v2/diagnostic-logs"
14241426
use_server_api = True
14251427
else:
14261428
if diagnostic_logs_url:
@@ -1435,8 +1437,8 @@ def send_logs(
14351437
)
14361438

14371439
# We send more from the local logs
1438-
global_logs_file_size_to_send = MAX_LOG_FILE_SIZE_TO_SEND * 0.2
1439-
local_logs_file_size_to_send = MAX_LOG_FILE_SIZE_TO_SEND * 0.8
1440+
global_logs_file_size_to_send = int(MAX_LOG_FILE_SIZE_TO_SEND * 0.2)
1441+
local_logs_file_size_to_send = int(MAX_LOG_FILE_SIZE_TO_SEND * 0.8)
14401442

14411443
global_logs = b""
14421444
if global_log_file and os.path.exists(global_log_file):
@@ -1454,7 +1456,7 @@ def send_logs(
14541456
header = {"content-type": "text/plain"}
14551457

14561458
if use_server_api:
1457-
return self.post(url, data=payload, headers=header)
1459+
return self.post(url, data=payload, headers=header, query_params=params)
14581460
else:
14591461
request = urllib.request.Request(url, data=payload, headers=header)
14601462
return self._do_request(request)

mergin/common.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
UPLOAD_CHUNK_SIZE = 10 * 1024 * 1024
88

99
# size of the log file part to send (if file is larger only this size from end will be sent)
10-
MAX_LOG_FILE_SIZE_TO_SEND = 8 * 1024 * 1024
10+
MAX_LOG_FILE_SIZE_TO_SEND = 5 * 1024 * 1024
1111

1212
# default URL for submitting logs
1313
MERGIN_DEFAULT_LOGS_URL = "https://g4pfq226j0.execute-api.eu-west-1.amazonaws.com/mergin_client_log_submit"

0 commit comments

Comments
 (0)