chore: fix props

Author: michalconsensys

src/components/elements/buttons/button/index.tsx

@@ -115,20 +115,43 @@ const Button = forwardRef<HTMLElement, ButtonProps>(
       textTransform !== 'none' && textTransform
     )
 
+    // Conditionally build props based on element type
+    const isLinkElement = asValue === 'link' || asValue === 'a'
+    const isButtonElement = asValue === 'button'
+    
+    const elementProps: Record<string, any> = {
+      ref: ref as React.Ref<any>,
+      'aria-label': ariaLabel,
+      onClick,
+      className: buttonClassNames,
+      style,
+      ...rest
+    }
+
+    // Add link-specific props only for link elements
+    if (isLinkElement) {
+      elementProps.href = href
+      if (external) {
+        elementProps.target = '_blank'
+        elementProps.rel = rel || 'noreferrer noopener'
+      } else if (rel) {
+        elementProps.rel = rel
+      }
+      if (download) {
+        elementProps.download = download
+      }
+    }
+
+    // Add button-specific props only for button elements
+    if (isButtonElement) {
+      elementProps.disabled = disabled
+      if (buttonType) {
+        elementProps.type = buttonType
+      }
+    }
+
     return (
-      <Component
-        ref={ref as React.Ref<any>}
-        href={asValue !== 'button' ? href : null}
-        target={asValue !== 'button' && external ? '_blank' : null}
-        rel={rel ? rel : external && asValue !== 'button' ? 'noreferrer noopener' : null}
-        aria-label={ariaLabel}
-        onClick={onClick}
-        className={buttonClassNames}
-        disabled={disabled}
-        download={as !== 'button' && download ? download : null}
-        style={style}
-        {...(asValue === 'button' && { type: buttonType })}
-        {...rest}>
+      <Component {...elementProps}>
         <span className={clsx(styles['button-holder'], labelBig && styles['label-big'])}>
           {children}
           {hasSpinner && <Spinner />}