From ab87cb7e0afc42064885cd89d048d8e0f272fd81 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 10:36:30 -0700 Subject: [PATCH 01/50] Update merge.yml --- .github/workflows/merge.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/merge.yml b/.github/workflows/merge.yml index 4b23a53d7..98555876a 100644 --- a/.github/workflows/merge.yml +++ b/.github/workflows/merge.yml @@ -13,20 +13,15 @@ jobs: runs-on: ubuntu-latest - strategy: - matrix: - node-version: [16.x] - steps: - uses: actions/checkout@v3 with: ref: 'next' fetch-depth: 0 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + - uses: actions/setup-node@v3 with: - node-version: ${{ matrix.node-version }} + node-version: 20 cache: 'npm' - run: npm ci - run: npm run build From 983fcfee6c375b433037bff7ad6036e6a4828730 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 10:38:18 -0700 Subject: [PATCH 02/50] Update lint-js.yml --- .github/workflows/lint-js.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/lint-js.yml b/.github/workflows/lint-js.yml index 6aca83a15..ed5290edd 100644 --- a/.github/workflows/lint-js.yml +++ b/.github/workflows/lint-js.yml @@ -14,17 +14,11 @@ jobs: runs-on: ubuntu-latest - strategy: - matrix: - node-version: [18] - # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ - steps: - uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + - uses: actions/setup-node@v3 with: - node-version: ${{ matrix.node-version }} + node-version: 20 cache: 'npm' - run: npm ci - run: npm run lint:js From 2f2d70f0d75f0295348facdb2e08115d9963705c Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 10:39:27 -0700 Subject: [PATCH 03/50] Update pr.yml --- .github/workflows/pr.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index f09b75bab..ae71d6c4a 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -13,16 +13,11 @@ jobs: runs-on: ubuntu-latest - strategy: - matrix: - node-version: [16.x] - steps: - uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + - uses: actions/setup-node@v3 with: - node-version: ${{ matrix.node-version }} + node-version: 20 cache: 'npm' - run: npm ci - run: npm run build From aa74558241f4e654443b8dd967e888fb8e2396be Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 10:40:39 -0700 Subject: [PATCH 04/50] Update rollback.yml --- .github/workflows/rollback.yml | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/rollback.yml b/.github/workflows/rollback.yml index f3c734765..79c1604d7 100644 --- a/.github/workflows/rollback.yml +++ b/.github/workflows/rollback.yml @@ -10,19 +10,14 @@ jobs: runs-on: ubuntu-latest - strategy: - matrix: - node-version: [16.x] - steps: - uses: actions/checkout@v3 with: ref: 'next' fetch-depth: 0 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + - uses: actions/setup-node@v3 with: - node-version: ${{ matrix.node-version }} + node-version: 20 cache: 'npm' - run: npm ci - run: npm run build From d77247145a840609b7f705bea1f69d913f51e721 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 10:48:24 -0700 Subject: [PATCH 05/50] Update test-js.yml --- .github/workflows/test-js.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test-js.yml b/.github/workflows/test-js.yml index 18b38822c..795dd253a 100644 --- a/.github/workflows/test-js.yml +++ b/.github/workflows/test-js.yml @@ -16,13 +16,12 @@ jobs: strategy: matrix: - node-version: [14, 16, 18] + node-version: [16, 18, 20, 22] # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ steps: - uses: actions/checkout@v3 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v3 + - uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} cache: 'npm' From 4daf147ae48d3b1eb7030abc83c348606e173b77 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:10:18 -0700 Subject: [PATCH 06/50] Update setup.yml --- .github/actions/setup.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 .github/actions/setup.yml diff --git a/.github/actions/setup.yml b/.github/actions/setup.yml new file mode 100644 index 000000000..3e132d2b0 --- /dev/null +++ b/.github/actions/setup.yml @@ -0,0 +1,20 @@ +name: Setup CI context +description: Sets up repo and Node context and installs packages + +inputs: + # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ + node-version: + type: number + default: 20 + description: The Node version to use + +runs: + using: composite + steps: + - uses: actions/checkout@v4 + # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ + - uses: actions/setup-node@v4 + with: + node-version: ${{ inputs.node-version }} + cache: npm + - run: npm ci \ No newline at end of file From 817fe337db5cb32accb5e4b7e8660cf682f33bdb Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:15:13 -0700 Subject: [PATCH 07/50] Rename .github/actions/setup.yml to .github/actions/setup/action.yml --- .github/actions/{setup.yml => setup/action.yml} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename .github/actions/{setup.yml => setup/action.yml} (96%) diff --git a/.github/actions/setup.yml b/.github/actions/setup/action.yml similarity index 96% rename from .github/actions/setup.yml rename to .github/actions/setup/action.yml index 3e132d2b0..9edeced0b 100644 --- a/.github/actions/setup.yml +++ b/.github/actions/setup/action.yml @@ -17,4 +17,4 @@ runs: with: node-version: ${{ inputs.node-version }} cache: npm - - run: npm ci \ No newline at end of file + - run: npm ci From f3cff422a5cf94aa00188818eb60328ebba5f274 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:17:25 -0700 Subject: [PATCH 08/50] Update lint-docs.yml --- .github/workflows/lint-docs.yml | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/.github/workflows/lint-docs.yml b/.github/workflows/lint-docs.yml index 52f3a0eef..bc7950e8f 100644 --- a/.github/workflows/lint-docs.yml +++ b/.github/workflows/lint-docs.yml @@ -1,6 +1,3 @@ -# This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node -# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions - name: lint-docs on: @@ -13,15 +10,7 @@ jobs: lint-docs: # https://github.com/MithrilJS/mithril.js/issues/2898 continue-on-error: true - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ - - uses: actions/setup-node@v3 - with: - node-version: 20 - cache: 'npm' - - run: npm ci + - uses: ./.github/actions/setup - run: npm run lint:docs From 0a79d32560e67b4ed57d4238ea90a9ebb6d11dd6 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:18:14 -0700 Subject: [PATCH 09/50] Update lint-js.yml --- .github/workflows/lint-js.yml | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/.github/workflows/lint-js.yml b/.github/workflows/lint-js.yml index ed5290edd..f2b4c8d75 100644 --- a/.github/workflows/lint-js.yml +++ b/.github/workflows/lint-js.yml @@ -1,6 +1,3 @@ -# This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node -# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions - name: lint-js on: @@ -11,14 +8,8 @@ on: jobs: lint-js: - runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 - with: - node-version: 20 - cache: 'npm' - - run: npm ci + - uses: ./.github/actions/setup - run: npm run lint:js From d813fe92f6d1189e12499599fd8a6e1d1c927bed Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:22:38 -0700 Subject: [PATCH 10/50] Update action.yml --- .github/actions/setup/action.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml index 9edeced0b..fa93400fb 100644 --- a/.github/actions/setup/action.yml +++ b/.github/actions/setup/action.yml @@ -2,6 +2,10 @@ name: Setup CI context description: Sets up repo and Node context and installs packages inputs: + branch: + type: string + default: next + description: The branch to fetch # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ node-version: type: number @@ -12,6 +16,9 @@ runs: using: composite steps: - uses: actions/checkout@v4 + with: + ref: ${{ inputs.branch }} + fetch-depth: 0 # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ - uses: actions/setup-node@v4 with: From 8263d1a7b27c94d4d9c437b2e4b29ae86d03564b Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:24:03 -0700 Subject: [PATCH 11/50] Update merge.yml --- .github/workflows/merge.yml | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/.github/workflows/merge.yml b/.github/workflows/merge.yml index 98555876a..1be1fd57c 100644 --- a/.github/workflows/merge.yml +++ b/.github/workflows/merge.yml @@ -14,16 +14,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - with: - ref: 'next' - fetch-depth: 0 - - - uses: actions/setup-node@v3 - with: - node-version: 20 - cache: 'npm' - - run: npm ci + - uses: ./.github/actions/setup - run: npm run build - run: npx pr-release merge --target master --source next --commit --force --clean --changelog ./docs/recent-changes.md --compact --minimize-semver-change env: From eb32ee18568d928a903b5a25ec4ad0a5442fd62a Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:24:43 -0700 Subject: [PATCH 12/50] Update action.yml --- .github/actions/setup/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml index fa93400fb..f3d9ad61b 100644 --- a/.github/actions/setup/action.yml +++ b/.github/actions/setup/action.yml @@ -4,7 +4,7 @@ description: Sets up repo and Node context and installs packages inputs: branch: type: string - default: next + required: true description: The branch to fetch # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ node-version: From 067e44f6a90f51ac2b0061ab32670709c81ca67a Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:25:13 -0700 Subject: [PATCH 13/50] Update lint-docs.yml --- .github/workflows/lint-docs.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/lint-docs.yml b/.github/workflows/lint-docs.yml index bc7950e8f..c2af291d7 100644 --- a/.github/workflows/lint-docs.yml +++ b/.github/workflows/lint-docs.yml @@ -13,4 +13,5 @@ jobs: runs-on: ubuntu-latest steps: - uses: ./.github/actions/setup + with: {branch: next} - run: npm run lint:docs From ee4050908ccfe3a67c503588d9e529567404d8bb Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:25:23 -0700 Subject: [PATCH 14/50] Update lint-js.yml --- .github/workflows/lint-js.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/lint-js.yml b/.github/workflows/lint-js.yml index f2b4c8d75..9924e4aa8 100644 --- a/.github/workflows/lint-js.yml +++ b/.github/workflows/lint-js.yml @@ -12,4 +12,5 @@ jobs: steps: - uses: ./.github/actions/setup + with: {branch: next} - run: npm run lint:js From 2b9ffb7f734c80452e21fa74ff0b6934e20dd5f3 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:25:34 -0700 Subject: [PATCH 15/50] Update merge.yml --- .github/workflows/merge.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/merge.yml b/.github/workflows/merge.yml index 1be1fd57c..123419228 100644 --- a/.github/workflows/merge.yml +++ b/.github/workflows/merge.yml @@ -15,6 +15,7 @@ jobs: steps: - uses: ./.github/actions/setup + with: {branch: next} - run: npm run build - run: npx pr-release merge --target master --source next --commit --force --clean --changelog ./docs/recent-changes.md --compact --minimize-semver-change env: From 264752f2da78f0d2bc356b257cd9f4c2eba41b09 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:25:49 -0700 Subject: [PATCH 16/50] Update pr.yml --- .github/workflows/pr.yml | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index ae71d6c4a..43ab4d002 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -14,12 +14,8 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 - with: - node-version: 20 - cache: 'npm' - - run: npm ci + - uses: ./.github/actions/setup + with: {branch: next} - run: npm run build - run: npx pr-release pr --verbose --target master --source next --compact --verbose --minimize-semver-change env: From bdc2a0bc52b52e55f19b21c5a4590ece0f4ea55a Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:28:31 -0700 Subject: [PATCH 17/50] Update rollback.yml --- .github/workflows/rollback.yml | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/.github/workflows/rollback.yml b/.github/workflows/rollback.yml index 79c1604d7..716781fab 100644 --- a/.github/workflows/rollback.yml +++ b/.github/workflows/rollback.yml @@ -11,15 +11,8 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - with: - ref: 'next' - fetch-depth: 0 - - uses: actions/setup-node@v3 - with: - node-version: 20 - cache: 'npm' - - run: npm ci + - uses: ./.github/actions/setup + with: {branch: next} - run: npm run build - run: npx pr-release rollback --verbose --target master --source next --verbose --ignore 'package*' --ignore docs/changelog.md --ignore docs/recent-changes.md env: From 7989713e045bebcad7f61c4b971705f01ddaed48 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:29:10 -0700 Subject: [PATCH 18/50] Update test-js.yml --- .github/workflows/test-js.yml | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test-js.yml b/.github/workflows/test-js.yml index 795dd253a..86a130506 100644 --- a/.github/workflows/test-js.yml +++ b/.github/workflows/test-js.yml @@ -20,10 +20,8 @@ jobs: # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: ./.github/actions/setup with: + branch: next node-version: ${{ matrix.node-version }} - cache: 'npm' - - run: npm ci - run: npm run test:js From c4365dd52fdfb5f05e92240d7a22e5fab812ceb4 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:44:42 -0700 Subject: [PATCH 19/50] Update action.yml --- .github/actions/setup/action.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml index f3d9ad61b..265aab3f6 100644 --- a/.github/actions/setup/action.yml +++ b/.github/actions/setup/action.yml @@ -3,12 +3,14 @@ description: Sets up repo and Node context and installs packages inputs: branch: - type: string - required: true - description: The branch to fetch - # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ + # Yanked from `actions/checkout`'s description for `ref`. + description: > + The branch, tag or SHA to checkout. When checking out the repository that + triggered a workflow, this defaults to the reference or SHA for that + event. Otherwise, uses the default branch. + # See supported Node.js release schedule here: + # https://github.com/nodejs/Release node-version: - type: number default: 20 description: The Node version to use @@ -19,9 +21,7 @@ runs: with: ref: ${{ inputs.branch }} fetch-depth: 0 - # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ - uses: actions/setup-node@v4 with: node-version: ${{ inputs.node-version }} - cache: npm - run: npm ci From 71f9dd1c073ca86f91cfc73cd153befe4c0def91 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:53:24 -0700 Subject: [PATCH 20/50] Update test-js.yml --- .github/workflows/test-js.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test-js.yml b/.github/workflows/test-js.yml index 86a130506..a58e70cc9 100644 --- a/.github/workflows/test-js.yml +++ b/.github/workflows/test-js.yml @@ -11,14 +11,15 @@ on: jobs: test-js: - runs-on: ubuntu-latest - strategy: matrix: - node-version: [16, 18, 20, 22] # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ - + node-version: + - 16 + - 18 + - 20 + - 22 steps: - uses: ./.github/actions/setup with: From 5cdd7f084086fe5e8cb6994a3539b81c475f7c94 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:53:33 -0700 Subject: [PATCH 21/50] Update test-js.yml --- .github/workflows/test-js.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/test-js.yml b/.github/workflows/test-js.yml index a58e70cc9..6d411bbb2 100644 --- a/.github/workflows/test-js.yml +++ b/.github/workflows/test-js.yml @@ -1,6 +1,3 @@ -# This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node -# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions - name: test-js on: From ccfe36db355878828321e494945c82ec30cfb64a Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:54:21 -0700 Subject: [PATCH 22/50] Update merge.yml --- .github/workflows/merge.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/merge.yml b/.github/workflows/merge.yml index 123419228..20ab71248 100644 --- a/.github/workflows/merge.yml +++ b/.github/workflows/merge.yml @@ -10,12 +10,12 @@ concurrency: prr:deploy jobs: merge: - runs-on: ubuntu-latest steps: - uses: ./.github/actions/setup - with: {branch: next} + with: + branch: next - run: npm run build - run: npx pr-release merge --target master --source next --commit --force --clean --changelog ./docs/recent-changes.md --compact --minimize-semver-change env: From 1eab83e53409c693114aa85eac9bf09b4d737f91 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:54:30 -0700 Subject: [PATCH 23/50] Update lint-docs.yml --- .github/workflows/lint-docs.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint-docs.yml b/.github/workflows/lint-docs.yml index c2af291d7..670f0d2a1 100644 --- a/.github/workflows/lint-docs.yml +++ b/.github/workflows/lint-docs.yml @@ -13,5 +13,6 @@ jobs: runs-on: ubuntu-latest steps: - uses: ./.github/actions/setup - with: {branch: next} + with: + branch: next - run: npm run lint:docs From 6d989465b9a092cc4a466b748b40fe2ab48a6b98 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:54:39 -0700 Subject: [PATCH 24/50] Update lint-js.yml --- .github/workflows/lint-js.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/lint-js.yml b/.github/workflows/lint-js.yml index 9924e4aa8..36ca6fdf4 100644 --- a/.github/workflows/lint-js.yml +++ b/.github/workflows/lint-js.yml @@ -12,5 +12,6 @@ jobs: steps: - uses: ./.github/actions/setup - with: {branch: next} + with: + branch: next - run: npm run lint:js From 76007c8e6b85e8c304d9570a7081c914353cf956 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:54:53 -0700 Subject: [PATCH 25/50] Update pr.yml --- .github/workflows/pr.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 43ab4d002..faa8e3227 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -10,12 +10,12 @@ concurrency: prr:pre-release jobs: pr: - runs-on: ubuntu-latest steps: - uses: ./.github/actions/setup - with: {branch: next} + with: + branch: next - run: npm run build - run: npx pr-release pr --verbose --target master --source next --compact --verbose --minimize-semver-change env: From 2a691364d006dece83324c7291db89a21e2693e0 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:55:08 -0700 Subject: [PATCH 26/50] Update rollback.yml --- .github/workflows/rollback.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/rollback.yml b/.github/workflows/rollback.yml index 716781fab..e4850618b 100644 --- a/.github/workflows/rollback.yml +++ b/.github/workflows/rollback.yml @@ -7,12 +7,12 @@ concurrency: prr:deploy jobs: pr: - runs-on: ubuntu-latest steps: - uses: ./.github/actions/setup - with: {branch: next} + with: + branch: next - run: npm run build - run: npx pr-release rollback --verbose --target master --source next --verbose --ignore 'package*' --ignore docs/changelog.md --ignore docs/recent-changes.md env: From 81cbbef2c98af66e45aef46c03cf2295650a01ae Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:58:16 -0700 Subject: [PATCH 27/50] Update test-js.yml --- .github/workflows/test-js.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test-js.yml b/.github/workflows/test-js.yml index 6d411bbb2..052964492 100644 --- a/.github/workflows/test-js.yml +++ b/.github/workflows/test-js.yml @@ -22,4 +22,5 @@ jobs: with: branch: next node-version: ${{ matrix.node-version }} + - run: npm run lint:js - run: npm run test:js From 1c8416ea48d21e5476a39ff6b7d94f415d9bdaf0 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 11:58:25 -0700 Subject: [PATCH 28/50] Update test-js.yml --- .github/workflows/test-js.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/test-js.yml b/.github/workflows/test-js.yml index 052964492..6d411bbb2 100644 --- a/.github/workflows/test-js.yml +++ b/.github/workflows/test-js.yml @@ -22,5 +22,4 @@ jobs: with: branch: next node-version: ${{ matrix.node-version }} - - run: npm run lint:js - run: npm run test:js From 05b307cb13ee2dca173dd6c5dd33adbee430f08a Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 13:13:56 -0700 Subject: [PATCH 29/50] Create test.yml --- .github/workflows/test.yml | 49 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 .github/workflows/test.yml diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml new file mode 100644 index 000000000..5022223f0 --- /dev/null +++ b/.github/workflows/test.yml @@ -0,0 +1,49 @@ +name: test + +on: + pull_request: + branches: [ next ] + workflow_dispatch: + workflow_call: + +permissions: + actions: write + contents: read + +jobs: + lint-docs: + # https://github.com/MithrilJS/mithril.js/issues/2898 + continue-on-error: true + runs-on: ubuntu-latest + steps: + - uses: ./.github/actions/setup + with: + branch: next + - run: npm run lint:docs + + lint-js: + runs-on: ubuntu-latest + steps: + - uses: ./.github/actions/setup + with: + branch: next + - run: npm run lint:js + + test-js: + needs: lint-js + runs-on: ubuntu-latest + strategy: + matrix: + # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ + node-version: + - 16 + - 18 + - 20 + - 22 + steps: + - uses: ./.github/actions/setup + with: + branch: next + node-version: ${{ matrix.node-version }} + - run: npm run build + - run: npm run test:js From 492c031994a371c7657f31efa49918abf6fb3faa Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 13:14:15 -0700 Subject: [PATCH 30/50] Delete .github/workflows/test-js.yml --- .github/workflows/test-js.yml | 25 ------------------------- 1 file changed, 25 deletions(-) delete mode 100644 .github/workflows/test-js.yml diff --git a/.github/workflows/test-js.yml b/.github/workflows/test-js.yml deleted file mode 100644 index 6d411bbb2..000000000 --- a/.github/workflows/test-js.yml +++ /dev/null @@ -1,25 +0,0 @@ -name: test-js - -on: - push: - branches: [ next ] - pull_request: - branches: [ next ] - -jobs: - test-js: - runs-on: ubuntu-latest - strategy: - matrix: - # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ - node-version: - - 16 - - 18 - - 20 - - 22 - steps: - - uses: ./.github/actions/setup - with: - branch: next - node-version: ${{ matrix.node-version }} - - run: npm run test:js From 36f802c3b96d1a5b17389b701e8f5a064400cee1 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 13:14:44 -0700 Subject: [PATCH 31/50] Delete .github/workflows/lint-docs.yml --- .github/workflows/lint-docs.yml | 18 ------------------ 1 file changed, 18 deletions(-) delete mode 100644 .github/workflows/lint-docs.yml diff --git a/.github/workflows/lint-docs.yml b/.github/workflows/lint-docs.yml deleted file mode 100644 index 670f0d2a1..000000000 --- a/.github/workflows/lint-docs.yml +++ /dev/null @@ -1,18 +0,0 @@ -name: lint-docs - -on: - push: - branches: [ next ] - pull_request: - branches: [ next ] - -jobs: - lint-docs: - # https://github.com/MithrilJS/mithril.js/issues/2898 - continue-on-error: true - runs-on: ubuntu-latest - steps: - - uses: ./.github/actions/setup - with: - branch: next - - run: npm run lint:docs From 0aedfb25bfcedf538c6bc98c9eedc4376ad0f7a7 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 13:14:53 -0700 Subject: [PATCH 32/50] Delete .github/workflows/lint-js.yml --- .github/workflows/lint-js.yml | 17 ----------------- 1 file changed, 17 deletions(-) delete mode 100644 .github/workflows/lint-js.yml diff --git a/.github/workflows/lint-js.yml b/.github/workflows/lint-js.yml deleted file mode 100644 index 36ca6fdf4..000000000 --- a/.github/workflows/lint-js.yml +++ /dev/null @@ -1,17 +0,0 @@ -name: lint-js - -on: - push: - branches: [ next ] - pull_request: - branches: [ next ] - -jobs: - lint-js: - runs-on: ubuntu-latest - - steps: - - uses: ./.github/actions/setup - with: - branch: next - - run: npm run lint:js From 268caaa549f57123ba90da573a645791f0f7acf8 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 13:16:16 -0700 Subject: [PATCH 33/50] Update and rename pr.yml to test-next-push.yml --- .github/workflows/{pr.yml => test-next-push.yml} | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) rename .github/workflows/{pr.yml => test-next-push.yml} (87%) diff --git a/.github/workflows/pr.yml b/.github/workflows/test-next-push.yml similarity index 87% rename from .github/workflows/pr.yml rename to .github/workflows/test-next-push.yml index faa8e3227..2355ade0d 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/test-next-push.yml @@ -1,17 +1,19 @@ -name: pr +name: test-next-push on: push: branches: [ next ] - workflow_dispatch: concurrency: prr:pre-release jobs: - pr: - runs-on: ubuntu-latest + build: + uses: ./.github/workflows/test.yml + publish-prerelease: + needs: build + runs-on: ubuntu-latest steps: - uses: ./.github/actions/setup with: From d4cb8b1085fb6d5ea9b78691fc9f198bb2a3778d Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 13:20:29 -0700 Subject: [PATCH 34/50] Update push-master.yml --- .github/workflows/push-master.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/push-master.yml b/.github/workflows/push-master.yml index 77bb6b87a..bec175c66 100644 --- a/.github/workflows/push-master.yml +++ b/.github/workflows/push-master.yml @@ -7,11 +7,11 @@ jobs: comment: runs-on: ubuntu-latest steps: - - uses: actions/github-script@v3 + - uses: actions/github-script@v7 with: github-token: ${{secrets.GITHUB_TOKEN}} script: | - await github.issues.createComment({ + await github.rest.issues.createComment({ issue_number: context.issue.number, owner: context.repo.owner, repo: context.repo.repo, From 9624e2185fd9407542d8929e71f68e007f9ed7ea Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 13:50:37 -0700 Subject: [PATCH 35/50] Update merge.yml --- .github/workflows/merge.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/merge.yml b/.github/workflows/merge.yml index 20ab71248..bcc6fa969 100644 --- a/.github/workflows/merge.yml +++ b/.github/workflows/merge.yml @@ -13,9 +13,11 @@ jobs: runs-on: ubuntu-latest steps: - - uses: ./.github/actions/setup + - uses: actions/checkout@v4 with: - branch: next + ref: next + fetch-depth: 0 + - uses: ./.github/actions/setup - run: npm run build - run: npx pr-release merge --target master --source next --commit --force --clean --changelog ./docs/recent-changes.md --compact --minimize-semver-change env: From d14b482c5bd480ad48ca12a887dcff031a0f0ccd Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 13:52:01 -0700 Subject: [PATCH 36/50] Update rollback.yml --- .github/workflows/rollback.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/rollback.yml b/.github/workflows/rollback.yml index e4850618b..6022b8fe9 100644 --- a/.github/workflows/rollback.yml +++ b/.github/workflows/rollback.yml @@ -10,9 +10,10 @@ jobs: runs-on: ubuntu-latest steps: - - uses: ./.github/actions/setup + - uses: actions/checkout@v4 with: - branch: next + ref: next + - uses: ./.github/actions/setup - run: npm run build - run: npx pr-release rollback --verbose --target master --source next --verbose --ignore 'package*' --ignore docs/changelog.md --ignore docs/recent-changes.md env: From 46a9329bddfb98d16e65e6cfb18352475fb29148 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 13:52:39 -0700 Subject: [PATCH 37/50] Update test-next-push.yml --- .github/workflows/test-next-push.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/test-next-push.yml b/.github/workflows/test-next-push.yml index 2355ade0d..c76b585a9 100644 --- a/.github/workflows/test-next-push.yml +++ b/.github/workflows/test-next-push.yml @@ -15,9 +15,8 @@ jobs: needs: build runs-on: ubuntu-latest steps: + - uses: actions/checkout@v4 - uses: ./.github/actions/setup - with: - branch: next - run: npm run build - run: npx pr-release pr --verbose --target master --source next --compact --verbose --minimize-semver-change env: From d6f0f69af43d91fe380a5347348c274c27b6f1a5 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 13:53:44 -0700 Subject: [PATCH 38/50] Update test.yml --- .github/workflows/test.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 5022223f0..49896af08 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -16,17 +16,15 @@ jobs: continue-on-error: true runs-on: ubuntu-latest steps: + - uses: actions/checkout@v4 - uses: ./.github/actions/setup - with: - branch: next - run: npm run lint:docs lint-js: runs-on: ubuntu-latest steps: + - uses: actions/checkout@v4 - uses: ./.github/actions/setup - with: - branch: next - run: npm run lint:js test-js: @@ -41,9 +39,9 @@ jobs: - 20 - 22 steps: + - uses: actions/checkout@v4 - uses: ./.github/actions/setup with: - branch: next node-version: ${{ matrix.node-version }} - run: npm run build - run: npm run test:js From 78b72e823532430b3beffced251e2e0403ff5e2c Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 13:54:07 -0700 Subject: [PATCH 39/50] Update action.yml --- .github/actions/setup/action.yml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml index 265aab3f6..68732d7ab 100644 --- a/.github/actions/setup/action.yml +++ b/.github/actions/setup/action.yml @@ -2,12 +2,6 @@ name: Setup CI context description: Sets up repo and Node context and installs packages inputs: - branch: - # Yanked from `actions/checkout`'s description for `ref`. - description: > - The branch, tag or SHA to checkout. When checking out the repository that - triggered a workflow, this defaults to the reference or SHA for that - event. Otherwise, uses the default branch. # See supported Node.js release schedule here: # https://github.com/nodejs/Release node-version: @@ -17,10 +11,6 @@ inputs: runs: using: composite steps: - - uses: actions/checkout@v4 - with: - ref: ${{ inputs.branch }} - fetch-depth: 0 - uses: actions/setup-node@v4 with: node-version: ${{ inputs.node-version }} From ac236f68c59006dfef7eb0f9e5446bb248f35b16 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 13:58:01 -0700 Subject: [PATCH 40/50] Update action.yml --- .github/actions/setup/action.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml index 68732d7ab..0504df800 100644 --- a/.github/actions/setup/action.yml +++ b/.github/actions/setup/action.yml @@ -15,3 +15,4 @@ runs: with: node-version: ${{ inputs.node-version }} - run: npm ci + shell: bash From a76a3888947e3f001cb128ea58593aad6b8a8318 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 14:05:50 -0700 Subject: [PATCH 41/50] Update test.yml --- .github/workflows/test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 49896af08..31719d233 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -16,14 +16,14 @@ jobs: continue-on-error: true runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - run: git clone --depth=0 https://github.com/MithrilJS/mithril.js.git && cd mithril.js - uses: ./.github/actions/setup - run: npm run lint:docs lint-js: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - run: git clone --depth=0 https://github.com/MithrilJS/mithril.js.git && cd mithril.js - uses: ./.github/actions/setup - run: npm run lint:js @@ -39,7 +39,7 @@ jobs: - 20 - 22 steps: - - uses: actions/checkout@v4 + - run: git clone --depth=0 https://github.com/MithrilJS/mithril.js.git && cd mithril.js - uses: ./.github/actions/setup with: node-version: ${{ matrix.node-version }} From 65c3cf7345324da848d527356057f5afcb89c519 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 14:06:21 -0700 Subject: [PATCH 42/50] Update merge.yml --- .github/workflows/merge.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/merge.yml b/.github/workflows/merge.yml index bcc6fa969..6f1f704b5 100644 --- a/.github/workflows/merge.yml +++ b/.github/workflows/merge.yml @@ -13,10 +13,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - with: - ref: next - fetch-depth: 0 + - run: git clone --depth=0 https://github.com/MithrilJS/mithril.js.git && cd mithril.js - uses: ./.github/actions/setup - run: npm run build - run: npx pr-release merge --target master --source next --commit --force --clean --changelog ./docs/recent-changes.md --compact --minimize-semver-change From c86fb00b526e9ec2c6a04ea007dfef96762376e9 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 14:07:32 -0700 Subject: [PATCH 43/50] Update rollback.yml --- .github/workflows/rollback.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/rollback.yml b/.github/workflows/rollback.yml index 6022b8fe9..57f2aacc7 100644 --- a/.github/workflows/rollback.yml +++ b/.github/workflows/rollback.yml @@ -10,9 +10,7 @@ jobs: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - with: - ref: next + - run: git clone --depth=0 https://github.com/MithrilJS/mithril.js.git && cd mithril.js - uses: ./.github/actions/setup - run: npm run build - run: npx pr-release rollback --verbose --target master --source next --verbose --ignore 'package*' --ignore docs/changelog.md --ignore docs/recent-changes.md From 865f70b8d8ca36b8ab5401437e3b38bcd0dc388a Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 14:07:55 -0700 Subject: [PATCH 44/50] Update test-next-push.yml --- .github/workflows/test-next-push.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-next-push.yml b/.github/workflows/test-next-push.yml index c76b585a9..c3aeef389 100644 --- a/.github/workflows/test-next-push.yml +++ b/.github/workflows/test-next-push.yml @@ -15,7 +15,7 @@ jobs: needs: build runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - run: git clone --depth=0 https://github.com/MithrilJS/mithril.js.git && cd mithril.js - uses: ./.github/actions/setup - run: npm run build - run: npx pr-release pr --verbose --target master --source next --compact --verbose --minimize-semver-change From 87d14d5c745a790a4080948a8a6fd67adba891bf Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 14:22:19 -0700 Subject: [PATCH 45/50] Update push-master.yml --- .github/workflows/push-master.yml | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/.github/workflows/push-master.yml b/.github/workflows/push-master.yml index bec175c66..3391c8c0d 100644 --- a/.github/workflows/push-master.yml +++ b/.github/workflows/push-master.yml @@ -1,19 +1,17 @@ -name: 'Push `master`' +name: Warn on pushing to `master` on: pull_request: types: [opened] - branches: ['master'] + branches: [master] +permissions: + issues: write jobs: comment: runs-on: ubuntu-latest steps: - - uses: actions/github-script@v7 - with: - github-token: ${{secrets.GITHUB_TOKEN}} - script: | - await github.rest.issues.createComment({ - issue_number: context.issue.number, - owner: context.repo.owner, - repo: context.repo.repo, - body: `⚠⚠⚠ Hey @${context.actor}, did you mean to open this against \`next\`? ⚠⚠⚠` - }) + - run: | + gh issue comment ${{ github.event.pull_request.url }} \ + --body '⚠⚠⚠ Hey @${{ github.actor }}, did you mean to open this against `next`? ⚠⚠⚠' + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + name: Post alert comment From 8554a28c3214553f26bab7c6ea7835ed0045ef48 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 14:27:43 -0700 Subject: [PATCH 46/50] Update test.yml --- .github/workflows/test.yml | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 31719d233..bc59f1407 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -27,9 +27,17 @@ jobs: - uses: ./.github/actions/setup - run: npm run lint:js - test-js: + build-js: needs: lint-js runs-on: ubuntu-latest + steps: + - run: git clone --depth=0 https://github.com/MithrilJS/mithril.js.git && cd mithril.js + - uses: ./.github/actions/setup + - run: npm run build + + test-js: + needs: build-js + runs-on: ubuntu-latest strategy: matrix: # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ @@ -43,5 +51,4 @@ jobs: - uses: ./.github/actions/setup with: node-version: ${{ matrix.node-version }} - - run: npm run build - run: npm run test:js From 41e4688813082087eecc4c60d2fab03f500ccd94 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 14:35:37 -0700 Subject: [PATCH 47/50] Update test.yml --- .github/workflows/test.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index bc59f1407..f10aa5a0c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -10,20 +10,23 @@ permissions: actions: write contents: read +# This uses actions/checkout instead of `git clone` directly since it's way +# easier than parsing everything out. + jobs: lint-docs: # https://github.com/MithrilJS/mithril.js/issues/2898 continue-on-error: true runs-on: ubuntu-latest steps: - - run: git clone --depth=0 https://github.com/MithrilJS/mithril.js.git && cd mithril.js + - run: actions/checkout@v4 - uses: ./.github/actions/setup - run: npm run lint:docs lint-js: runs-on: ubuntu-latest steps: - - run: git clone --depth=0 https://github.com/MithrilJS/mithril.js.git && cd mithril.js + - run: actions/checkout@v4 - uses: ./.github/actions/setup - run: npm run lint:js @@ -31,7 +34,7 @@ jobs: needs: lint-js runs-on: ubuntu-latest steps: - - run: git clone --depth=0 https://github.com/MithrilJS/mithril.js.git && cd mithril.js + - run: actions/checkout@v4 - uses: ./.github/actions/setup - run: npm run build @@ -47,7 +50,7 @@ jobs: - 20 - 22 steps: - - run: git clone --depth=0 https://github.com/MithrilJS/mithril.js.git && cd mithril.js + - run: actions/checkout@v4 - uses: ./.github/actions/setup with: node-version: ${{ matrix.node-version }} From 0e89237a1837aa36fc2cbf34b9f9546786496987 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 14:43:09 -0700 Subject: [PATCH 48/50] Update action.yml --- .github/actions/setup/action.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml index 0504df800..7cf6a6d41 100644 --- a/.github/actions/setup/action.yml +++ b/.github/actions/setup/action.yml @@ -1,3 +1,6 @@ +# In the future, I'd like to fold this into its own action under the Mithril.js +# org and include `actions/checkout` as well. It'd simplify maintenance a bit +# and I could reuse it across multiple repos. name: Setup CI context description: Sets up repo and Node context and installs packages From 486a3d94d8fdca6749ecb36e34414775c6fc2fe7 Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 14:52:19 -0700 Subject: [PATCH 49/50] Update test.yml --- .github/workflows/test.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f10aa5a0c..9e835e21d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -16,6 +16,8 @@ permissions: jobs: lint-docs: # https://github.com/MithrilJS/mithril.js/issues/2898 + # Semantics aren't quite what I'd prefer. This is what I'd really want: + # https://github.com/actions/runner/issues/2347#issue-comment-box continue-on-error: true runs-on: ubuntu-latest steps: From a34966cc9a7304e5b22dd6d5e766af03f55964dc Mon Sep 17 00:00:00 2001 From: Claudia Meadows Date: Sun, 25 Aug 2024 14:53:59 -0700 Subject: [PATCH 50/50] Update test.yml --- .github/workflows/test.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 9e835e21d..d54ae7e5a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -21,14 +21,14 @@ jobs: continue-on-error: true runs-on: ubuntu-latest steps: - - run: actions/checkout@v4 + - uses: actions/checkout@v4 - uses: ./.github/actions/setup - run: npm run lint:docs lint-js: runs-on: ubuntu-latest steps: - - run: actions/checkout@v4 + - uses: actions/checkout@v4 - uses: ./.github/actions/setup - run: npm run lint:js @@ -36,7 +36,7 @@ jobs: needs: lint-js runs-on: ubuntu-latest steps: - - run: actions/checkout@v4 + - uses: actions/checkout@v4 - uses: ./.github/actions/setup - run: npm run build @@ -52,7 +52,7 @@ jobs: - 20 - 22 steps: - - run: actions/checkout@v4 + - uses: actions/checkout@v4 - uses: ./.github/actions/setup with: node-version: ${{ matrix.node-version }}