Use @build_bazel_apple_support//constraints:device in selects (#3198)

Signed-off-by: Brentley Jones <github@brentleyjones.com>

Author: brentleyjones

examples/integration/AppClip/BUILD

@@ -17,13 +17,6 @@ config_setting(
     },
 )
 
-config_setting(
-    name = "device_build",
-    values = {
-        "cpu": "ios_arm64",
-    },
-)
-
 ios_app_clip(
     name = "AppClip",
     app_icons = glob(["Assets.xcassets/AppIcon.appiconset/**"]),
@@ -34,7 +27,7 @@ ios_app_clip(
     infoplists = [":Info.plist"],
     minimum_os_version = "15.0",
     provisioning_profile = select({
-        ":device_build": ":xcode_profile",
+        "@build_bazel_apple_support//constraints:device": ":xcode_profile",
         "//conditions:default": None,
     }),
     resources = [":ResourceGroup"],

examples/integration/ExtensionKitExtension/BUILD

@@ -8,13 +8,6 @@ load(
     "TEAMID",
 )
 
-config_setting(
-    name = "device_build",
-    values = {
-        "cpu": "ios_arm64",
-    },
-)
-
 ios_extension(
     name = "ExtensionKitExtension",
     bundle_id = "{}.extensionkit-extension".format(IOS_BUNDLE_ID),
@@ -23,7 +16,7 @@ ios_extension(
     infoplists = [":Info.plist"],
     minimum_os_version = "15.0",
     provisioning_profile = select({
-        ":device_build": ":xcode_profile",
+        "@build_bazel_apple_support//constraints:device": ":xcode_profile",
         "//conditions:default": None,
     }),
     version = "//iOSApp:Version",

examples/integration/WidgetExtension/BUILD

@@ -13,21 +13,14 @@ load(
     "TEAMID",
 )
 
-config_setting(
-    name = "device_build",
-    values = {
-        "cpu": "ios_arm64",
-    },
-)
-
 ios_extension(
     name = "WidgetExtension",
     bundle_id = "{}.widget-extension".format(IOS_BUNDLE_ID),
     families = ["iphone"],
     infoplists = ["Info.plist"],
     minimum_os_version = "15.0",
     provisioning_profile = select({
-        ":device_build": ":xcode_profile",
+        "@build_bazel_apple_support//constraints:device": ":xcode_profile",
         "//conditions:default": None,
     }),
     resources = [":ResourceGroup"],

examples/integration/iOSApp/Source/BUILD

@@ -20,13 +20,6 @@ config_setting(
     },
 )
 
-config_setting(
-    name = "device_build",
-    values = {
-        "cpu": "ios_arm64",
-    },
-)
-
 ios_application(
     name = "iOSApp",
     alternate_icons = glob(["AltIcons/AltIcon-60.alticon/**"]),
@@ -48,7 +41,7 @@ ios_application(
     }),
     entitlements = "ios app.entitlements",
     executable_name = select({
-        ":device_build": None,
+        "@build_bazel_apple_support//constraints:device": None,
         "//conditions:default": "iOSApp_ExecutableName",
     }),
     extensions = [
@@ -62,16 +55,18 @@ ios_application(
     ],
     infoplists = [":Info.plist"],
     launch_images = select({
-        ":device_build": glob(["launch_images_ios.xcassets/**"]),
+        "@build_bazel_apple_support//constraints:device": glob(
+            ["launch_images_ios.xcassets/**"],
+        ),
         "//conditions:default": [],
     }),
     launch_storyboard = select({
-        ":device_build": None,
+        "@build_bazel_apple_support//constraints:device": None,
         "//conditions:default": "Launch.storyboard",
     }),
     minimum_os_version = "15.0",
     provisioning_profile = select({
-        ":device_build": ":xcode_profile",
+        "@build_bazel_apple_support//constraints:device": ":xcode_profile",
         "//conditions:default": None,
     }),
     resources = [

examples/integration/tvOSApp/Source/BUILD

@@ -15,13 +15,6 @@ config_setting(
     },
 )
 
-config_setting(
-    name = "device_build",
-    values = {
-        "cpu": "tvos_arm64",
-    },
-)
-
 tvos_application(
     name = "tvOSApp",
     bundle_id = TVOS_BUNDLE_ID,
@@ -30,7 +23,7 @@ tvos_application(
     infoplists = [":Info.plist"],
     minimum_os_version = "15.0",
     provisioning_profile = select({
-        ":device_build": ":xcode_profile",
+        "@build_bazel_apple_support//constraints:device": ":xcode_profile",
         "//conditions:default": None,
     }),
     resources = ["//tvOSApp/Resources:ResourceGroup"],

examples/integration/watchOSApp/BUILD

@@ -8,13 +8,6 @@ load(
     "WATCHOS_BUNDLE_ID",
 )
 
-config_setting(
-    name = "device_build",
-    values = {
-        "cpu": "watchos_arm64_32",
-    },
-)
-
 watchos_application(
     name = "watchOSApp",
     app_icons = ["AppIcon.xcassets"],
@@ -23,7 +16,7 @@ watchos_application(
     infoplists = [":infoplist"],
     minimum_os_version = "8.0",
     provisioning_profile = select({
-        ":device_build": ":xcode_profile",
+        "@build_bazel_apple_support//constraints:device": ":xcode_profile",
         "//conditions:default": None,
     }),
     version = "//iOSApp:Version",

examples/integration/watchOSAppExtension/BUILD

@@ -16,13 +16,6 @@ config_setting(
     },
 )
 
-config_setting(
-    name = "device_build",
-    values = {
-        "cpu": "watchos_arm64_32",
-    },
-)
-
 watchos_extension(
     name = "watchOSAppExtension",
     bundle_id = "{}.extension".format(WATCHOS_BUNDLE_ID),
@@ -31,7 +24,7 @@ watchos_extension(
     minimum_deployment_os_version = "8.0",
     minimum_os_version = "7.0",
     provisioning_profile = select({
-        ":device_build": ":xcode_profile",
+        "@build_bazel_apple_support//constraints:device": ":xcode_profile",
         "//conditions:default": None,
     }),
     resources = [":ResourceGroup"],

examples/rules_ios/WidgetExtension/BUILD

@@ -19,21 +19,14 @@ load(
     "TEAMID",
 )
 
-config_setting(
-    name = "device_build",
-    values = {
-        "cpu": "ios_arm64",
-    },
-)
-
 rules_ios_ios_extension(
     name = "WidgetExtension",
     bundle_id = "{}.widget-extension".format(IOS_BUNDLE_ID),
     families = ["iphone"],
     infoplists = ["Info.plist"],
     minimum_os_version = "15.0",
     provisioning_profile = select({
-        ":device_build": ":xcode_profile",
+        "@build_bazel_apple_support//constraints:device": ":xcode_profile",
         "//conditions:default": None,
     }),
     resources = [":ResourceGroup"],

examples/rules_ios/iOSApp/Source/BUILD

@@ -23,13 +23,6 @@ config_setting(
     },
 )
 
-config_setting(
-    name = "device_build",
-    values = {
-        "cpu": "ios_arm64",
-    },
-)
-
 rules_ios_ios_application(
     name = "iOSApp",
     app_icons = glob(["Assets.xcassets/AppIcon.appiconset/**"]),
@@ -43,7 +36,7 @@ rules_ios_ios_application(
     launch_storyboard = "Launch.storyboard",
     minimum_os_version = "15.0",
     provisioning_profile = select({
-        ":device_build": ":xcode_profile",
+        "@build_bazel_apple_support//constraints:device": ":xcode_profile",
         "//conditions:default": None,
     }),
     resource_bundles = {