✨ MCP Tool test run #541

Author: jiangpeiling

backend/apps/tool_config_app.py

@@ -13,7 +13,7 @@
     update_tool_list,
     list_all_tools,
     load_last_tool_config_impl,
-    validate_tools,
+    validate_tool_impl,
 )
 from utils.auth_utils import get_current_user_id
 
@@ -110,7 +110,7 @@ async def validate_tool(
     """Validate specific tool based on source type"""
     try:
         _, tenant_id = get_current_user_id(authorization)
-        result = await validate_tools(request, tenant_id)
+        result = await validate_tool_impl(request, tenant_id)
 
         return JSONResponse(
             status_code=HTTPStatus.OK,

backend/services/tool_configuration_service.py

@@ -628,7 +628,7 @@ def _validate_langchain_tool(
             f"LangChain tool '{tool_name}' validation failed: {e}")
 
 
-async def validate_tools(
+async def validate_tool_impl(
     request: ToolValidateRequest,
     tenant_id: Optional[str] = None
 ) -> Dict[str, Any]:

test/backend/app/test_tool_config_app.py

@@ -1,4 +1,3 @@
-from consts.exceptions import MCPConnectionError, NotFoundException
 from unittest.mock import patch, MagicMock
 import sys
 import os
@@ -10,6 +9,7 @@
 sys.modules['boto3'] = MagicMock()
 
 # Import exception classes
+from consts.exceptions import MCPConnectionError, NotFoundException
 
 # Mock dependencies before importing the actual app - using the same pattern as test_remote_mcp_app.py
 with patch('database.client.MinioClient', MagicMock()):
@@ -305,7 +305,7 @@ def test_missing_parameters(self):
         assert response.status_code == HTTPStatus.UNPROCESSABLE_ENTITY
 
     @patch('apps.tool_config_app.get_current_user_id')
-    @patch('apps.tool_config_app.validate_tools')
+    @patch('apps.tool_config_app.validate_tool_impl')
     def test_validate_tool_success(self, mock_validate_tool, mock_get_user_id):
         """Test successful tool validation"""
         mock_get_user_id.return_value = ("user123", "tenant456")
@@ -332,7 +332,7 @@ def test_validate_tool_success(self, mock_validate_tool, mock_get_user_id):
         mock_validate_tool.assert_called_once()
 
     @patch('apps.tool_config_app.get_current_user_id')
-    @patch('apps.tool_config_app.validate_tools')
+    @patch('apps.tool_config_app.validate_tool_impl')
     def test_validate_tool_mcp_connection_error(self, mock_validate_tool, mock_get_user_id):
         """Test MCP connection error during tool validation"""
         mock_get_user_id.return_value = ("user123", "tenant456")
@@ -357,7 +357,7 @@ def test_validate_tool_mcp_connection_error(self, mock_validate_tool, mock_get_u
         mock_validate_tool.assert_called_once()
 
     @patch('apps.tool_config_app.get_current_user_id')
-    @patch('apps.tool_config_app.validate_tools')
+    @patch('apps.tool_config_app.validate_tool_impl')
     def test_validate_tool_not_found_error(self, mock_validate_tool, mock_get_user_id):
         """Test tool not found error during validation"""
         mock_get_user_id.return_value = ("user123", "tenant456")
@@ -381,7 +381,7 @@ def test_validate_tool_not_found_error(self, mock_validate_tool, mock_get_user_i
         mock_validate_tool.assert_called_once()
 
     @patch('apps.tool_config_app.get_current_user_id')
-    @patch('apps.tool_config_app.validate_tools')
+    @patch('apps.tool_config_app.validate_tool_impl')
     def test_validate_tool_general_error(self, mock_validate_tool, mock_get_user_id):
         """Test general error during tool validation"""
         mock_get_user_id.return_value = ("user123", "tenant456")
@@ -426,7 +426,7 @@ def test_validate_tool_auth_error(self, mock_get_user_id):
         mock_get_user_id.assert_called_once_with(None)
 
     @patch('apps.tool_config_app.get_current_user_id')
-    @patch('apps.tool_config_app.validate_tools')
+    @patch('apps.tool_config_app.validate_tool_impl')
     def test_validate_tool_with_authorization_header(self, mock_validate_tool, mock_get_user_id):
         """Test tool validation with authorization header"""
         mock_get_user_id.return_value = ("user123", "tenant456")

test/backend/services/test_config_sync_service.py

@@ -754,7 +754,6 @@ async def test_load_config_impl_chinese(self, service_mocks):
 
         # Check Chinese default values
         assert result["app"]["name"] == "Nexent 智能体"
-        assert "Nexent 是一个开源智能体SDK和平台" in result["app"]["description"]
 
     @pytest.mark.asyncio
     async def test_load_config_impl_with_embedding_dimension(self, service_mocks):

test/backend/services/test_tool_configuration_service.py

@@ -1,6 +1,3 @@
-from apps.tool_config_app import validate_tool
-from consts.exceptions import MCPConnectionError, NotFoundException, ToolExecutionException
-from consts.model import ToolInfo, ToolSourceEnum, ToolInstanceInfoRequest, ToolValidateRequest
 import asyncio
 import inspect
 import sys
@@ -21,8 +18,10 @@
         search_tool_info_impl,
         update_tool_info_impl,
         list_all_tools,
-        load_last_tool_config_impl, validate_tools
+        load_last_tool_config_impl, validate_tool_impl
 )
+from consts.exceptions import MCPConnectionError, NotFoundException, ToolExecutionException
+from consts.model import ToolInfo, ToolSourceEnum, ToolInstanceInfoRequest, ToolValidateRequest
 
 
 class TestPythonTypeToJsonSchema:
@@ -1422,7 +1421,7 @@ async def test_validate_tool_nexent(self, mock_validate_nexent):
             inputs={"param": "value"}
         )
 
-        result = await validate_tools(request, "tenant1")
+        result = await validate_tool_impl(request, "tenant1")
 
         assert result == "nexent result"
         mock_validate_nexent.assert_called_once_with(
@@ -1440,7 +1439,7 @@ async def test_validate_tool_remote(self, mock_validate_remote):
             inputs={"param": "value"}
         )
 
-        result = await validate_tools(request, "tenant1")
+        result = await validate_tool_impl(request, "tenant1")
 
         assert result == "remote result"
         mock_validate_remote.assert_called_once_with(
@@ -1459,7 +1458,7 @@ async def test_validate_tool_local(self, mock_validate_local):
             params={"config": "value"}
         )
 
-        result = await validate_tools(request, "tenant1")
+        result = await validate_tool_impl(request, "tenant1")
 
         assert result == "local result"
         mock_validate_local.assert_called_once_with(
@@ -1477,7 +1476,7 @@ async def test_validate_tool_langchain(self, mock_validate_langchain):
             inputs={"param": "value"}
         )
 
-        result = await validate_tools(request, "tenant1")
+        result = await validate_tool_impl(request, "tenant1")
 
         assert result == "langchain result"
         mock_validate_langchain.assert_called_once_with(
@@ -1493,7 +1492,7 @@ async def test_validate_tool_unsupported_source(self):
         )
 
         with pytest.raises(ToolExecutionException, match="Validate Tool failed"):
-            await validate_tools(request, "tenant1")
+            await validate_tool_impl(request, "tenant1")
 
     @patch('backend.services.tool_configuration_service._validate_mcp_tool_nexent')
     async def test_validate_tool_nexent_connection_error(self, mock_validate_nexent):
@@ -1508,10 +1507,8 @@ async def test_validate_tool_nexent_connection_error(self, mock_validate_nexent)
             inputs={"param": "value"}
         )
 
-        from backend.services.tool_configuration_service import validate_tools
-
         with pytest.raises(MCPConnectionError, match="MCP connection failed: Connection failed"):
-            await validate_tools(request, "tenant1")
+            await validate_tool_impl(request, "tenant1")
 
     @patch('backend.services.tool_configuration_service._validate_local_tool')
     async def test_validate_tool_local_execution_error(self, mock_validate_local):
@@ -1526,10 +1523,8 @@ async def test_validate_tool_local_execution_error(self, mock_validate_local):
             params={"config": "value"}
         )
 
-        from backend.services.tool_configuration_service import validate_tools
-
         with pytest.raises(ToolExecutionException, match="Validate Tool failed"):
-            await validate_tools(request, "tenant1")
+            await validate_tool_impl(request, "tenant1")
 
 
 if __name__ == '__main__':