Skip to content

Commit 4e21f6a

Browse files
authored
Merge pull request #236 from denny0223/master
Refactor and enhance connection settings
2 parents af2e6ba + 27d6ace commit 4e21f6a

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,4 @@ that much better:
3232
* Jérôme Lafréchoux (Nobatek) - http://nobatek.com
3333
* Bruno Belarmino - https://github.com/brunobelarmino
3434
* Sibelius Seraphini - https://github.com/sibelius
35+
* Denny Huang - https://github.com/denny0223

flask_mongoengine/connection.py

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -240,16 +240,17 @@ def _register_test_connection(port, db_alias, preserved):
240240
def _resolve_settings(conn_setting, removePass=True):
241241

242242
if conn_setting and isinstance(conn_setting, dict):
243-
alias = conn_setting.get('MONGODB_ALIAS',
244-
conn_setting.get('alias', conn_setting.get('ALIAS', DEFAULT_CONNECTION_NAME)))
245-
db = conn_setting.get('MONGODB_DB', conn_setting.get('db', conn_setting.get('DB', 'test')))
246-
host = conn_setting.get('MONGODB_HOST', conn_setting.get('host', conn_setting.get('HOST', 'localhost')))
247-
port = conn_setting.get('MONGODB_PORT', conn_setting.get('port', conn_setting.get('PORT', 27017)))
248-
username = conn_setting.get('MONGODB_USERNAME', conn_setting.get('username', conn_setting.get('USERNAME', None)))
249-
password = conn_setting.get('MONGODB_PASSWORD', conn_setting.get('password', conn_setting.get('PASSWORD', None)))
243+
conn_setting = dict(((k[8:] if k.startswith("MONGODB_") else k), v) for k, v in conn_setting.items() if v is not None)
244+
conn_setting = dict((k.lower(), v) for k, v in conn_setting.items())
245+
246+
alias = conn_setting.get('alias', DEFAULT_CONNECTION_NAME)
247+
db = conn_setting.get('db', 'test')
248+
host = conn_setting.get('host', 'localhost')
249+
port = conn_setting.get('port', 27017)
250+
username = conn_setting.get('username', None)
251+
password = conn_setting.get('password', None)
250252
# Default to ReadPreference.PRIMARY if no read_preference is supplied
251-
read_preference = conn_setting.get('MONGODB_READ_PREFERENCE',
252-
conn_setting.get('read_preference', ReadPreference.PRIMARY))
253+
read_preference = conn_setting.get('read_preference', ReadPreference.PRIMARY)
253254

254255
resolved = {}
255256
resolved['read_preference'] = read_preference

0 commit comments

Comments
 (0)