Skip to content

Use shadow DOM or different class names #3

@RaminGe

Description

@RaminGe

Hey there,

It would make lots of sense to add the image viewer as shadow DOM element instead of just adding it to the body, or at least rename the classes and add some suffix or prefix. Right now the viewer uses the class name container which is widely used by many css libraries and can infer with the styles of the image viewer.

E.g. in this case the container class has a max width set globally and therefore also limits the image viewer (which of cource should still be displayed in fullscreen):
img-viewer-width

This could be resolved by renaming the classes used to e.g. ìmg-viewer-container or use the shadow DOM.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions