Use explicit conditions in booleans inside role 'monitoring_plugins'

gianmarco-mameli · Donien · web-flow · commit d0ea8f2e9610 · 2025-11-10T16:25:09.000+01:00
* Refactor conditionals to ensure proper evaluation of package lists in Debian, RedHat, and Suse installation tasks

---------

Co-authored-by: Donien &lt;88634789+Donien@users.noreply.github.com&gt;
diff --git a/changelogs/fragments/fix_broken_conditionals.yml b/changelogs/fragments/fix_broken_conditionals.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - "Use explicit booleans in conditions inside of role :code:`monitoring_plugins` for compatibility with :code:`ansible-core >= 2.19`. Thanks @gianmarco-mameli"
diff --git a/roles/monitoring_plugins/tasks/install_on_Debian.yml b/roles/monitoring_plugins/tasks/install_on_Debian.yml
@@ -10,7 +10,7 @@
   changed_when: apt_result.stdout is defined
   when:
     - needed_packages is defined
-    - needed_packages
+    - needed_packages | length > 0
 
 - name: Apt - remove non-requested packages
   become: yes
@@ -20,4 +20,4 @@
     autoremove: "{{ icinga_monitoring_plugins_autoremove }}"
   when:
     - icinga_monitoring_plugins_remove
-    - unwanted_packages
+    - unwanted_packages | length > 0
diff --git a/roles/monitoring_plugins/tasks/install_on_RedHat.yml b/roles/monitoring_plugins/tasks/install_on_RedHat.yml
@@ -14,7 +14,7 @@
   when:
     - ansible_distribution_major_version < "8"
     - needed_packages is defined
-    - needed_packages
+    - needed_packages | length > 0
 
 - name: Dnf - install requested packages
   become: yes
@@ -26,7 +26,7 @@
   when:
     - ansible_distribution_major_version >= "8"
     - needed_packages is defined
-    - needed_packages
+    - needed_packages | length > 0
 
 - name: Yum - remove non-requested packages
   become: yes
@@ -36,4 +36,4 @@
     autoremove: "{{ icinga_monitoring_plugins_autoremove }}"
   when:
     - icinga_monitoring_plugins_remove
-    - unwanted_packages
+    - unwanted_packages | length > 0
diff --git a/roles/monitoring_plugins/tasks/install_on_Suse.yml b/roles/monitoring_plugins/tasks/install_on_Suse.yml
@@ -10,7 +10,7 @@
   changed_when: zypper_result.stdout is defined
   when:
     - needed_packages is defined
-    - needed_packages
+    - needed_packages | length > 0
 
 - name: Zypper - remove non-requested packages
   become: yes
@@ -20,4 +20,4 @@
     clean_deps: "{{ icinga_monitoring_plugins_autoremove }}"
   when:
     - icinga_monitoring_plugins_remove
-    - unwanted_packages
+    - unwanted_packages | length > 0

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+bugfixes:`
	`2`	+ - "Use explicit booleans in conditions inside of role :code:`monitoring_plugins` for compatibility with :code:`ansible-core >= 2.19`. Thanks @gianmarco-mameli"