-
-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Apparently Pako v2.* has some breaking changes that prevent us from updating it without deep investigation.
Problematic code in this library:
git-essentials/src/utils/git-list-pack.ts
Lines 48 to 51 in d793ac5
inflator.push(chunk, false) | |
if (inflator.err) { | |
throw new InternalError(`Pako error: ${inflator.msg}`) | |
} |
Problematic code on pako library:
https://github.com/nodeca/pako/blob/174a1d12b68dfbd531a572eaaea0937491b36f55/lib/inflate.js#L237-L245
// Skip snyc markers if more data follows and not raw mode
while (strm.avail_in > 0 &&
status === Z_STREAM_END &&
strm.state.wrap > 0 &&
data[strm.next_in] !== 0)
{
zlib_inflate.inflateReset(strm);
status = zlib_inflate.inflate(strm, _flush_mode);
}
this does not exist in Pako v1.* and causes the following error in Inflator
Err: -3, msg: 'incorrect header check'
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request