Could the Html property on OEmbedResponse perhaps return an HtmlString

[soreng]

I notice the use of Html.Raw ... could the Html property perhaps return an HtmlString instead,? That way the property can be rendered "straight up".

EDIT: this is not the place for such a comment. Sorry. My mistake! But now it's here - should it stay or should it go?

Originally posted by @jannikanker in #10 (comment)

[soreng]

It would need some testing if changed, and would also be a bit Breaking.

the html part of the response may / may not, be filled, so there needs to be checks to decide what to render.

It may be an idea to ship with a (partial) view that can render a non-styled version of the output, bit I would suggest having the documentation in place before changing code.

The OembedResponse is also the entity being returned by the OEmbed provider. Not quite sure how deserialising json to an object with an HtmlString-property.

[bjarnef]

Or maybe IHtmlString like many extension methods in Umbraco core?

[soreng]

Or maybe IHtmlString like many extension methods in Umbraco core?

IHtmlString is IHtmlContent in AspNetCore :)

I can see a few ways to make this work.

One way would be to create multiple versions of the OEmbedResponse. One for storing the response, and another version for rendering. The rendering version could then have a Html typed as IHtmlContent. In order to do this, the property value converter would then implement the mapping.

Another way, would be to "store" the IHtmlContent. This would then allow to only have a single version of the OEmbedResponse, but moving the "mapping" to the services that may / may not, know that they are used for anything AspNetCore related.

you would still need multiple types for this to work

Of the two, I would prefer the first.