address feedback

Author: fadi-george

src/entries/worker.ts

@@ -3,5 +3,5 @@
  */
 import { run } from '../sw/serviceWorker/ServiceWorker';
 
-// The run() is already called in ServiceWorker.ts, but importing it ensures it's not tree-shaken
-void run;
+// Need to call run() to ensure the service worker is registered but also to ensure the service worker is not tree-shaken
+run();

src/shared/services/limitStore.ts

@@ -1,11 +1,11 @@
 /*
- LimitStore.put('colorado', 'rocky');
+ limitStorePut('colorado', 'rocky');
  ["rocky"]
- LimitStore.put('colorado', 'mountain');
+ limitStorePut('colorado', 'mountain');
  ["rocky", "mountain"]
- LimitStore.put('colorado', 'national');
+ limitStorePut('colorado', 'national');
  ["mountain", "national"]
- LimitStore.put('colorado', 'park');
+ limitStorePut('colorado', 'park');
  ["national", "park"]
  */
 const LIMIT = 2;
@@ -16,7 +16,7 @@ export function limitStorePut<T>(key: string, value: T) {
     store[key] = [null, null];
   }
   store[key].push(value);
-  if (store[key].length == LIMIT + 1) {
+  if (store[key].length === LIMIT + 1) {
     store[key].shift();
   }
   return store[key];

src/sw/serviceWorker/ServiceWorker.test.ts

@@ -31,7 +31,7 @@ import type {
   UpsertOrDeactivateSessionPayload,
 } from 'src/shared/session/types';
 import { NotificationType } from 'src/shared/subscriptions/constants';
-import { getAppId } from './ServiceWorker';
+import { getAppId, run } from './ServiceWorker';
 
 // Mock webhook notification events
 vi.mock('../webhooks/notifications/webhookNotificationEvent', () => ({
@@ -53,6 +53,8 @@ const appId = APP_ID;
 const notificationId = 'test-notification-id';
 const version = __VERSION__;
 
+run();
+
 vi.useFakeTimers();
 vi.setSystemTime('2025-01-01T00:08:00.000Z');
 vi.spyOn(Log, '_debug').mockImplementation(() => {});

src/sw/serviceWorker/ServiceWorker.ts

@@ -1111,5 +1111,3 @@ function parseOrFetchNotifications(
     `Unexpected push message payload received: ${event.data}`,
   );
 }
-
-run();