Cleanup and simplification.

Author: electricessence

benchmarking/Benchmark.cs

@@ -1,7 +1,6 @@
 using Open.Diagnostics;
 using System;
 using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
 using System.Threading.Tasks;
 
 #if DEBUG
@@ -10,7 +9,6 @@
 
 namespace Open.Disposable.ObjectPools
 {
-	[SuppressMessage("ReSharper", "AccessToDisposedClosure")]
 	public class Benchmark<T> : BenchmarkBase<Func<IObjectPool<T>>>
 		where T : class
 	{

benchmarking/Program.cs

@@ -2,13 +2,11 @@
 using Open.Disposable.ObjectPools;
 using Open.Text.CSV;
 using System;
-using System.Diagnostics.CodeAnalysis;
 using System.IO;
 using System.Text;
 
 class Program
 {
-	[SuppressMessage("ReSharper", "CoVariantArrayConversion")]
 	static void Main()
 	{
 		Console.Write("Initializing...");

source/Array/InterlockedArrayObjectPool.cs

@@ -33,7 +33,6 @@ public InterlockedArrayObjectPool(Func<T> factory, int capacity = DEFAULT_CAPACI
 		public override int Count
 			=> Pool.Count(e => e.Value != null) + PocketCount;
 
-		[System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Should never be null.")]
 		protected virtual bool Store(ReferenceContainer<T>[] p, T item, int index)
 			=> p[index].TrySave(item);
 

source/Array/OptimisticArrayObjectPool.cs

@@ -25,7 +25,6 @@ protected override bool SaveToPocket(T item)
 			=> Pocket.SetIfNull(item);
 
 		// As suggested by Roslyn's implementation, don't worry about interlocking here.  It's okay if a few get loose.
-		[System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "Should never be null.")]
 		protected override bool Store(ReferenceContainer<T>[] p, T item, int index)
 			=> p[index].SetIfNull(item);
 	}

source/IObjectPool.cs

@@ -6,7 +6,6 @@
 
 namespace Open.Disposable
 {
-	[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
 	public interface IObjectPool<T> : IDisposable
 		where T : class
 	{

source/ObjectPoolAutoTrimmer.cs

@@ -4,7 +4,6 @@
 
 namespace Open.Disposable
 {
-	[SuppressMessage("ReSharper", "FieldCanBeMadeReadOnly.Local")]
 	[SuppressMessage("Style", "IDE0044:Add readonly modifier", Justification = "Micro-optimization for retrieving this value as read-only is slightly slower")]
 	public class ObjectPoolAutoTrimmer : DisposableBase
 	{

source/Open.Disposable.ObjectPools.csproj

@@ -4,6 +4,7 @@
 		<TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
 		<LangVersion>latest</LangVersion>
 		<Nullable>enable</Nullable>
+		<EnableNETAnalyzers>true</EnableNETAnalyzers>
 		<RootNamespace>Open.Disposable</RootNamespace>
 		<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
 		<Authors>electricessence</Authors>

source/Recycler.cs

@@ -60,14 +60,14 @@ public static Recycler<T> CreateRecycler<T>(
 			Action<T> recycleFunction,
 			ushort limit = Constants.DEFAULT_CAPACITY)
 			where T : class
-			=> new Recycler<T>(pool, recycleFunction, limit);
+			=> new(pool, recycleFunction, limit);
 
 		public static Recycler<T> CreateRecycler<T>(
 			this IObjectPool<T> pool,
 			ushort limit,
 			Action<T> recycleFunction)
 			where T : class
-			=> new Recycler<T>(pool, recycleFunction, limit);
+			=> new(pool, recycleFunction, limit);
 
 		public static void Recycle(IRecyclable r)
 			=> (r ?? throw new ArgumentNullException(nameof(r))).Recycle();
@@ -76,6 +76,6 @@ public static Recycler<T> CreateRecycler<T>(
 			this IObjectPool<T> pool,
 			ushort limit = Constants.DEFAULT_CAPACITY)
 			where T : class, IRecyclable
-			=> new Recycler<T>(pool, Recycle, limit);
+			=> new(pool, Recycle, limit);
 	}
 }

source/RecyclerBase.cs

@@ -22,7 +22,7 @@ protected RecyclerBase(
 			Target = target ?? throw new ArgumentNullException(nameof(target));
 			Contract.EndContractBlock();
 
-			if (!(target is DisposableBase d)) return;
+			if (target is not DisposableBase d) return;
 			if (d.WasDisposed) throw new ArgumentException("Cannot recycle for an object pool that is already disposed.");
 			d.BeforeDispose += Pool_BeforeDispose;
 			// Could possibly dispose before this line somewhere... But that's just nasty. :P 

source/ReferenceContainer.cs

@@ -1,10 +1,8 @@
 using System.Diagnostics;
-using System.Diagnostics.CodeAnalysis;
 using System.Threading;
 
 namespace Open.Disposable
 {
-	[SuppressMessage("ReSharper", "UnusedMemberInSuper.Global")]
 	public interface IReferenceContainer<T>
 		where T : class
 	{
@@ -15,7 +13,6 @@ public interface IReferenceContainer<T>
 	}
 
 	[DebuggerDisplay("{Value,nq}")]
-	[SuppressMessage("Performance", "CA1815:Override equals and operator equals on value types", Justification = "Undesired.")]
 	public struct ReferenceContainer<T> : IReferenceContainer<T>
 		where T : class
 	{