[client] More not empty for updating

Author: Samuel Hassine

pycti/entities/opencti_intrusion_set.py

@@ -341,15 +341,15 @@ def create(self, **kwargs):
                     object_result["name"] = name
                 # description
                 if (
-                    description is not None
+                    self.opencti.not_empty(description)
                     and object_result["description"] != description
                 ):
                     self.opencti.stix_domain_entity.update_field(
                         id=object_result["id"], key="description", value=description
                     )
                     object_result["description"] = description
                 # alias
-                if alias is not None and object_result["alias"] != alias:
+                if self.opencti.not_empty(alias) and object_result["alias"] != alias:
                     if "alias" in object_result:
                         new_aliases = object_result["alias"] + list(
                             set(alias) - set(object_result["alias"])
@@ -373,14 +373,14 @@ def create(self, **kwargs):
                     )
                     object_result["last_seen"] = last_seen
                 # goal
-                if goal is not None and object_result["goal"] != goal:
+                if self.opencti.not_empty(goal) and object_result["goal"] != goal:
                     self.opencti.stix_domain_entity.update_field(
                         id=object_result["id"], key="goal", value=goal
                     )
                     object_result["goal"] = goal
                 # sophistication
                 if (
-                    sophistication is not None
+                    self.opencti.not_empty(sophistication)
                     and object_result["sophistication"] != sophistication
                 ):
                     self.opencti.stix_domain_entity.update_field(
@@ -391,7 +391,7 @@ def create(self, **kwargs):
                     object_result["sophistication"] = sophistication
                 # resource_level
                 if (
-                    resource_level is not None
+                    self.opencti.not_empty(resource_level)
                     and object_result["resource_level"] != resource_level
                 ):
                     self.opencti.stix_domain_entity.update_field(
@@ -402,7 +402,7 @@ def create(self, **kwargs):
                     object_result["resource_level"] = resource_level
                 # primary_motivation
                 if (
-                    primary_motivation is not None
+                    self.opencti.not_empty(primary_motivation)
                     and object_result["primary_motivation"] != primary_motivation
                 ):
                     self.opencti.stix_domain_entity.update_field(
@@ -413,7 +413,7 @@ def create(self, **kwargs):
                     object_result["primary_motivation"] = primary_motivation
                 # secondary_motivation
                 if (
-                    secondary_motivation is not None
+                    self.opencti.not_empty(secondary_motivation)
                     and object_result["secondary_motivation"] != secondary_motivation
                 ):
                     self.opencti.stix_domain_entity.update_field(

pycti/entities/opencti_malware.py

@@ -324,23 +324,26 @@ def create(self, **kwargs):
                     object_result["name"] = name
                 # description
                 if (
-                    description is not None
+                    self.opencti.not_empty(description)
                     and object_result["description"] != description
                 ):
                     self.opencti.stix_domain_entity.update_field(
                         id=object_result["id"], key="description", value=description
                     )
                     object_result["description"] = description
                 # is_family
-                if is_family is not None and object_result["is_family"] != is_family:
+                if (
+                    self.opencti.not_empty(is_family)
+                    and object_result["is_family"] != is_family
+                ):
                     self.opencti.stix_domain_entity.update_field(
                         id=object_result["id"],
                         key="is_family",
                         value=str(is_family).lower(),
                     )
                     object_result["is_family"] = is_family
                 # alias
-                if alias is not None and object_result["alias"] != alias:
+                if self.opencti.not_empty(alias) and object_result["alias"] != alias:
                     if "alias" in object_result:
                         new_aliases = object_result["alias"] + list(
                             set(alias) - set(object_result["alias"])